Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-220376328
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-219194930
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-219191877
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-219190157
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-219186514
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-219108516
There are now merge conflicts on this branch, before we can test on the CI,
this needs to be rebased.
---
If your project is set up for it, you can reply to this e
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-218782620
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-218525666
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user shaygalon commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-203657654
For the 64K page size, a multiple of kernel page size would be fine and
more future proof. It would be better to have it as a variable and not a
constant, and a
Github user PSUdaemon commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-202990616
This kinda feels like it should be three separate PR's.
f304c50a2c00d7d711015c981b2007dacdf159b7 - seems probably ok, simply
because if it's wrong it wo
Github user shaygalon commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-199982414
For x86 you actually have to sign extend the lower bit otherwise on AMD
systems you would be addressing the wrong address... The meaning of the bits
>48 is arch
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/502#issuecomment-199877909
@PSUdaemon to review, the thought it as that at least the freelist bit
mask is a clearer solution for all platforms.
---
If your project is set up for it, you can
12 matches
Mail list logo
