[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-20 Thread calavera
Github user calavera commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-220679375 @jpeach I made some changes in ConfigVolumes::BuildListFromString to handle the un-ordered options too. I could not find those generic parsing routines but I can

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-220376299 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-13 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-219194914 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-13 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-219191865 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-13 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-219190138 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-13 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-219186488 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-218782561 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-11 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-218525599 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-06 Thread calavera
Github user calavera commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-217479501 Thanks @jpeach. I'll look into that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-06 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-217472293 I haven't had time to look at this properly, but ``volume.config`` is not (only) parsed by the management routines, it is parsed by ``ConfigVolumes::BuildListFromS

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-06 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-217454573 Assigning to @PSUdaemon for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-05 Thread calavera
GitHub user calavera opened a pull request: https://github.com/apache/trafficserver/pull/618 [TS-4408] Make volume.config not order sensitive. I added a couple of additional checks: 1. Fail with a format error if there are duplicated tokens, for instance: volume