Github user ericcarlschwartz closed the pull request at:
https://github.com/apache/trafficserver/pull/598
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if th
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-220376302
.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-219194917
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-219191868
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-219190142
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-219186494
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-218782575
Can one of the admins verify this patch? Only approve PRs which have been
reviewed.
---
If your project is set up for it, you can reply to this email and have your
Github user atsci commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-218525630
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pro
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214471698
I agree with @jacksontj , having an API here makes sense. Then you defer
any penalty cost to the actual usage of such APIs as well (so no cost when not
used).
---
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214471034
Right, I think the correct way was my option #2-- which would be to have an
API for getting this info (basically another mgmt API endpoint like hostdb,
stats, e
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214469357
@jacksontj Having it part of the existing metrics would mean you would have
a metric per origin. We went down that road before and created a stats v2
which was
Github user JamesPeach commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214464758
A log field to mark whether a server session was re-used seems helpful, but
a very different patch from what is being proposed here.
---
If your project is se
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214463886
@jacksontj the way we are using it on the log entries is as a boolean (zero
or non-zero) to understand whether that request was able to reuse an existing
origin
Github user JamesPeach commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214463141
@bryancall AFAICT ``server_connection_count`` is always populated, which is
hitting a global lock. If there's no consensus that this is the right approach
then
Github user jacksontj commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214452613
@bryancall My main point here is that putting this in the access logs isn't
the right place to put it as the transactions have little to do with the
connections
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214452495
Right, I meant, maybe it should be an option to enable these per origin
metrics in the core. At which point, the generic "metric" log tag would work,
right?
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214452145
It is configurable to turn it off and on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214451815
Gotcha. Maybe that should be a regular metric instead then? Per-origin
metric? Although, that has to be configurable to turn off, because it could
explode in your f
18 matches
Mail list logo
