[GitHub] trafficserver pull request: [TS-4243] Collapsed Forwarding Plugin ...

2016-03-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/505 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: [TS-4243] Collapsed Forwarding Plugin ...

2016-02-29 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/505#issuecomment-190326183 Thanks, @jpeach : updated with the comments and squashed the commits. --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] trafficserver pull request: [TS-4243] Collapsed Forwarding Plugin ...

2016-02-29 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/505#issuecomment-190322100 I'm OK with a separate commit. Can you please remove ``rcsId__header_normalize_cc`` and make all the internal functions and data ``static``? --- If your project

[GitHub] trafficserver pull request: [TS-4243] Collapsed Forwarding Plugin ...

2016-02-29 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/505#issuecomment-190321453 @jpeach: clang-formatted the source file. Was planning to add docs (will need to spend some time) in a separate commit after the plugin gets in. Would you rather

[GitHub] trafficserver pull request: [TS-4243] Collapsed Forwarding Plugin ...

2016-02-29 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/505#issuecomment-190320120 Needs documentation and ``clang-format`` :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver pull request: [TS-4243] Collapsed Forwarding Plugin ...

2016-02-29 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/505#issuecomment-190316226 @zwoop : could you pls review? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] trafficserver pull request: [TS-4243] Collapsed Forwarding Plugin ...

2016-02-29 Thread sudheerv
GitHub user sudheerv opened a pull request: https://github.com/apache/trafficserver/pull/505 [TS-4243] Collapsed Forwarding Plugin based on Open Write Fail Action… … feature. You can merge this pull request into a Git repository by running: $ git pull https://github.com/apa