Github user jrushf1239k commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-187279799
I can't build the master branch since this was added, I think that the
plugins/experimental/Makefile.am needs to be changed:
- stream_editor \
- w
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/393
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186383393
@zwoop @shukitchan made changes as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If yo
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186362474
Nit picking, but instead of BUILD_WEBP_TRANSFORM_PLUGIN, wouldn't it make
more sense to just say something like BUILD_HAS_IMAGEMAGICCPP or some such
(look for some
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186080875
I am :+1: as well
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r53426210
--- Diff: doc/admin-guide/plugins/webp_transform.en.rst ---
@@ -0,0 +1,38 @@
+.. _webp_transform:
+
+WebpTransform Plugin
+**
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186076071
Wow, yes this much cleaner by using ImageMagik. I'm :+1: with this. Anyone
else have comments?
---
If your project is set up for it, you can reply to this email an
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r53425864
--- Diff: plugins/experimental/webp_transform/ImageTransform.cc ---
@@ -0,0 +1,109 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) und
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186013102
@bgaff can you review now. Using ImageMagick makes the code much cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-168846815
@bgaff I reused some of the code from libwebp examples and so there is a
mix of C and C++. I will check if Imagemagick can be used to abstract image
specific detai
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-168113227
Just out of curiosity was some of this code taken as examples from the
libraries you're using? Also, it seems there is a lot of image specific code in
this plugin t
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r48644987
--- Diff: plugins/experimental/webp_transform/metadata.h ---
@@ -0,0 +1,52 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r48644849
--- Diff: plugins/experimental/webp_transform/compress.cc ---
@@ -0,0 +1,198 @@
+/** @file
+
+ATSCPPAPI plugin to do webp transform.
+
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r48644738
--- Diff: plugins/experimental/webp_transform/metadata.cc ---
@@ -0,0 +1,64 @@
+/**
+ Licensed to the Apache Software Foundation (ASF) under one
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r48644645
--- Diff: plugins/experimental/webp_transform/compress.cc ---
@@ -0,0 +1,198 @@
+/** @file
+
+ATSCPPAPI plugin to do webp transform.
+
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r48644607
--- Diff: plugins/experimental/webp_transform/compress.cc ---
@@ -0,0 +1,198 @@
+/** @file
+
+ATSCPPAPI plugin to do webp transform.
+
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-168111940
@bgaff This seems useful that it ought to be more than just an example, no
? Do we have a strategy / plan for exposing stable plugins to the community,
which are u
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r48644527
--- Diff: plugins/experimental/webp_transform/compress.cc ---
@@ -0,0 +1,198 @@
+/** @file
+
+ATSCPPAPI plugin to do webp transform.
+
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167855489
@shukitchan done with c-lang formating.
@mlibbey good idea to have a remap plugin. Will work on it once this PR is
merged.
---
If your project is set up for
Github user mlibbey commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167851931
Think my feature request would be to allow this to be a remap plugin
instead of only a global one -- so it could be enabled in much more specific
cases.
---
If
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167850957
seems good. would be great if you can run clang-format on this
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167030403
Something like this -
https://github.com/apache/trafficserver/blob/master/doc/admin-guide/plugins/esi.en.rst
And it should be refered in here -
https:
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167018043
What should the document consist? The design of the plugin ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167015374
Also we should write a document if we are putting this into experimental
plugin directory
---
If your project is set up for it, you can reply to this email an
Github user shukitchan commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/393#discussion_r48389749
--- Diff: lib/atscppapi/examples/webp_transform/README ---
@@ -0,0 +1,6 @@
+onverting jpeg and png to webp
--- End diff --
small typ
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167011245
refactored the code to follow naming conventions as suggested by
@shukitchan .
please review.
---
If your project is set up for it, you can reply to this
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-166764391
@bgaff I made the suggested changes. Also added license agreement.
@shukitchan I am working on c-lang formatting and update the PR.
---
If your projec
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-166739688
2 more comments
1) Please add an ASF license blurb to all new files
2) you can also run clang-format to beautify your code a bit as well. Check
out
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-166471944
@shukitchan we could easily move it to experimental. Probably have to check
additional flags in Makefile.am under experimental.
Once @bgaff is Ok I can work on
Github user shukitchan commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-166470972
need some time to go through the code. But @bgaff, any objection to put it
in experimental plugin instead of example/ ?
---
If your project is set up for it,
GitHub user myraid opened a pull request:
https://github.com/apache/trafficserver/pull/393
[TS-4095] adding a new example plugin for converting jpeg/png to webpâ¦
@shukitchan @bgaff can you review and merge the PR.
You can merge this pull request into a Git repository by running:
31 matches
Mail list logo
