[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-09 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/763 This might be above my Git skill level. I did try to pull the PR into my tree, but it's so far behind that it made some crazy changes / conflicts :-/. Manually applying the "diff" from this PR,

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-09 Thread PSUdaemon
Github user PSUdaemon commented on the issue: https://github.com/apache/trafficserver/pull/763 Yes, merge and mark what files you resolved conflicts in. Git normally puts this in the commented part of the commit message so just make sure you uncomment before commit. --- If your proj

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/763 I resolved the conflicts, I think: http://paste.fedoraproject.org/389174/80381301/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/763 It does have merge conflicts, so maybe I should resolve that locally, and commit it with --author=susan ? @PSUdaemon wdyt? --- If your project is set up for it, you can reply to this email and

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-08 Thread masaori335
Github user masaori335 commented on the issue: https://github.com/apache/trafficserver/pull/763 @zwoop Looks good. We should land this to add a option to get metrics per protocol. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-08 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/763 @shinrich @masaori335 Should we land this patch though? I'm landing my other fix for the active client conns. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-06 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/763 Yes, that fix does not address active client connection. It wasn't immediately clear to me what that meant for HTTP2. So I fixed the others but left active client connections alone.

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-05 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/763 Some sort of odd race condition here maybe. If I run single requests using curl, I'm not seeing the problem. But if I blast it with "ab -c 10 -n 1" the counter permanently bumps up by 10,000

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-07-05 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/763 So, I tried this patch, and it does not fix the problem I'm running into, where proxy.process.http.current_active_client_connections is seemingly never decremented. I had a merge conflict, but I

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-06-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/763 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/274/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #763: TS-4610: Fix HTTP and HTTP2 stats

2016-06-28 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/763 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/378/ for details. --- If your project is set up for it, you can reply to this email and have your r