[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-17 Thread bgaff
Github user bgaff commented on the issue: https://github.com/apache/trafficserver/pull/720 Sorry I was referring specifically to the config ( the txn config set enums ) but I think this solves that too. Please land this, thanks for doing it! --- If your project is set up fo

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/720 > we should do the same with all the ink config stuff rather than including ink_config I'm not sure what you mean by this. This patch is removing {{ink_autoconf.h}} from the public C++

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/188/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/296/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/720 Not sure why the FreeBSD build failed, trying again. [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/187/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/295/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/186/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/720 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/294/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #720: TS-4560: Fix C++ API shared_ptr detection.

2016-06-16 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/720 Ping @bgaff @SolidWallOfCode --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled