Re: [API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-06 Thread Brian Geffon
Alan, Take a look at the final commit, we're on the same page. Brian On Thu, Nov 6, 2014 at 1:38 PM, Alan M. Carroll wrote: > We are simply incapable of doing anything in a simple way. > > I see James' point but I disagree with his implementation. > > I would recommend setting the refcount to 1

Re: [API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-06 Thread Alan M. Carroll
We are simply incapable of doing anything in a simple way. I see James' point but I disagree with his implementation. I would recommend setting the refcount to 1 on allocate and doing just > if (mutextp->refcount_dec() == 0) { > mutextp->free(); >

Re: [API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-05 Thread Leif Hedstrom
> On Nov 4, 2014, at 6:20 PM, Brian Geffon wrote: > > This should be self explanatory and IMO we should land for 5.2, the > following patch is also attached to TS-1432. I obviously haven’t tested it, but seems straightforward and useful. +1 — leif

Re: [API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-05 Thread James Peach
> On Nov 4, 2014, at 4:20 PM, Brian Geffon wrote: > > This should be self explanatory and IMO we should land for 5.2, the > following patch is also attached to TS-1432. +1 on the API For the implementation, I think you should take reference counting into account. Maybe something along these l

[API REVIEW] TS-1432 API is missing TSMutexDestroy

2014-11-04 Thread Brian Geffon
This should be self explanatory and IMO we should land for 5.2, the following patch is also attached to TS-1432. Brian diff --git a/proxy/InkIOCoreAPI.cc b/proxy/InkIOCoreAPI.cc index 26f3298..091d7a2 100644 --- a/proxy/InkIOCoreAPI.cc +++ b/proxy/InkIOCoreAPI.cc @@ -189,6 +189,11 @@ TSMutexCre