Re: [API REVIEW] SSL support extensions

2014-09-08 Thread James Peach
On Sep 5, 2014, at 8:15 AM, Susan Hinrichs wrote: > > On 9/4/2014 7:33 PM, James Peach wrote: >> On Aug 28, 2014, at 12:16 PM, Susan Hinrichs >> wrote: >> >>> This was discussed a couple weeks back and some changes made in response. >>> Here it is again in the proper form. Would like to

Re: [API REVIEW] SSL support extensions

2014-09-05 Thread James Peach
On Sep 5, 2014, at 9:33 AM, Susan Hinrichs wrote: > Quick question on naming consistency. James, you propose > > tsapi TSSslConnection TSVConnSSLConnectionGet(TSVConn); > > In this signature, we are using SSL both all capitalized (in the function > name) and mixed case (in the type name). >

Re: [API REVIEW] SSL support extensions

2014-09-05 Thread Susan Hinrichs
Quick question on naming consistency. James, you propose tsapi TSSslConnection TSVConnSSLConnectionGet(TSVConn); In this signature, we are using SSL both all capitalized (in the function name) and mixed case (in the type name). I see that SSL in a function name has precedent in TSHttpSsnSSLCo

Re: [API REVIEW] SSL support extensions

2014-09-05 Thread Susan Hinrichs
On 9/4/2014 7:33 PM, James Peach wrote: On Aug 28, 2014, at 12:16 PM, Susan Hinrichs wrote: This was discussed a couple weeks back and some changes made in response. Here it is again in the proper form. Would like to get this merged up now that 5.1 is wrapping up. JIRA ticket https://i

Re: [API REVIEW] SSL support extensions

2014-09-04 Thread James Peach
On Aug 28, 2014, at 12:16 PM, Susan Hinrichs wrote: > This was discussed a couple weeks back and some changes made in response. > Here it is again in the proper form. Would like to get this merged up now > that 5.1 is wrapping up. > > JIRA ticket https://issues.apache.org/jira/browse/TS-30

[API REVIEW] SSL support extensions

2014-08-28 Thread Susan Hinrichs
This was discussed a couple weeks back and some changes made in response. Here it is again in the proper form. Would like to get this merged up now that 5.1 is wrapping up. JIRA ticket https://issues.apache.org/jira/browse/TS-3006 and related ticket https://issues.apache.org/jira/browse/TS-