> On Nov 15, 2017, at 8:33 AM, Alan Carroll
> wrote:
>
> 1) Generally the hook names aren't conjugated, more like
> 'TS_VCONN_CONNECT_HOOK' and 'TS_VCONN_ACCEPT_HOOK'.
> 2) 'TS_VCONN_CLOSE_HOOK' is required. That's one the the issues that
> sparked all of this, the inability to have a hook whe
1) Generally the hook names aren't conjugated, more like
'TS_VCONN_CONNECT_HOOK' and 'TS_VCONN_ACCEPT_HOOK'.
2) 'TS_VCONN_CLOSE_HOOK' is required. That's one the the issues that
sparked all of this, the inability to have a hook where VConn related data
can be cleaned up.
On Wed, Nov 15, 2017 at 9:
Yes, Origin Server. :-)
TS_VCONN_CONNECTED_HOOK maybe more accurate than TS_VCONN_OPENED_HOOK for
"once a connection is established"
- Oknet
2017-11-15 23:08 GMT+08:00 Alan Carroll :
> Ah, by "OS" you mean "Origin Server", not "Operating System".
>
> On Wed, Nov 15, 2017 at 9:06 AM, Chao Xu wr
Ah, by "OS" you mean "Origin Server", not "Operating System".
On Wed, Nov 15, 2017 at 9:06 AM, Chao Xu wrote:
> TS_VCONN_OPENED_HOOK for OS side and TS_VCONN_ACCEPTED_HOOK for client
> side.
>
> - Oknet
>
> 2017-11-15 23:04 GMT+08:00 Alan Carroll invalid>:
>
> > How are those different? In term
TS_VCONN_OPENED_HOOK for OS side and TS_VCONN_ACCEPTED_HOOK for client side.
- Oknet
2017-11-15 23:04 GMT+08:00 Alan Carroll :
> How are those different? In terms of names, if you want consistency then
> TS_NET_ACCEPT_HOOK might be the best choice, aligning with
> TS_EVENT_NET_ACCEPT which is th
IMO, It is time to pull the ssl hooks from TSHttpHookID enum.
```
typedef enum {
TS_VCONN_FIRST_HOOK,
TS_VCONN_ACCEPTED_HOOK = TS_VCONN_FIRST_HOOK,
TS_VCONN_SSL_SNI_HOOK,
TS_VCONN_SSL_CERT_HOOK = TS_VCONN_SSL_SNI_HOOK,
TS_VCONN_SSL_SERVERNAME_HOOK,
TS_VCONN_OPENED_HOOK,
TS_VCONN_SSL_
How are those different? In terms of names, if you want consistency then
TS_NET_ACCEPT_HOOK might be the best choice, aligning with
TS_EVENT_NET_ACCEPT which is the event that signals that action.
On Wed, Nov 15, 2017 at 8:58 AM, Chao Xu wrote:
> Hi AMC,
>
> " We should rename TS_VCONN_PRE_ACCEP
Hi AMC,
" We should rename TS_VCONN_PRE_ACCEPT_HOOK to TS_VCONN_START_HOOK. "
IMO, TS_VCONN_OPENED_HOOK when the OS connection is established.
TS_VCONN_ACCEPTED_HOOK as a instead for TS_VCONN_PRE_ACCEPT_HOOK.
- Oknet
2017-11-14 23:48 GMT+08:00 Dk Jack :
> I concur with the idea that connection
I concur with the idea that connection level APIs should be different from
the
HTTP txn or ssn level APIs. For my use case, I am saving attributes at the
connection
level and accessing them during HTTP txn processing.
On Tue, Nov 14, 2017 at 6:11 AM, Alan Carroll <
solidwallofc...@oath.com.invalid
I thought we'd discussed this already, but I think having the same index
for all three is a bad API design. I think the use cases are generally
separate and conflating them effectively reduces the size of the arrays. If
I could, I'd change the TXN and SSN args to use separate indices and would
be
> On Nov 8, 2017, at 11:08 PM, Alan M. Carroll
> wrote:
>
> This came up with issues #2380 and #2388 and PR #2783. I had been waiting for
> some internal feedback on my proposal but since this is now active I am
> sending in my API proposal for attaching plugin data to NetVConnections
> (TS
> On Nov 8, 2017, at 11:08 PM, Alan M. Carroll
> wrote:
>
> This came up with issues #2380 and #2388 and PR #2783. I had been waiting for
> some internal feedback on my proposal but since this is now active I am
> sending in my API proposal for attaching plugin data to NetVConnections
> (TS
This came up with issues #2380 and #2388 and PR #2783. I had been waiting for
some internal feedback on my proposal but since this is now active I am sending
in my API proposal for attaching plugin data to NetVConnections (TSVConn).
https://solidwallofcode.github.io/api/TSVConnArgs.en.html#tsvco
13 matches
Mail list logo
