Re: [API PROPOSAL] TSIpAddrParse

2017-09-17 Thread Alan Carroll
The primary issue with exposing parts of ts/lib is concern about the C++ ABI breaking on minor and point releases. It may be that with more modern compilers this is less of an issue but we need to either verify that or become much more careful about changes in those files. This problem doesn't aris

Re: [API PROPOSAL] TSIpAddrParse

2017-09-15 Thread Chao Xu
Why we don't expose the ts/lib for plugins ? I think the ts/lib is an alternative for libstdc++. Oknet Xu 2017-09-15 22:29 GMT+08:00 Alan Carroll : > Well, my goal has been to, at some point, make all of ink_inet.h available > to plugins. This seems a reasonable start. > > On Sep 14, 2017 6:09

Re: [API PROPOSAL] TSIpAddrParse

2017-09-15 Thread Alan Carroll
Well, my goal has been to, at some point, make all of ink_inet.h available to plugins. This seems a reasonable start. On Sep 14, 2017 6:09 PM, "Shu Kit Chan" wrote: > Here is the PR for this. > > https://github.com/apache/trafficserver/pull/2520 > > Thanks. > > Kit > > On Wed, Sep 13, 2017 at 2:

Re: [API PROPOSAL] TSIpAddrParse

2017-09-14 Thread Shu Kit Chan
Here is the PR for this. https://github.com/apache/trafficserver/pull/2520 Thanks. Kit On Wed, Sep 13, 2017 at 2:55 PM, Shu Kit Chan wrote: > Hi all, > > I would like to see if there is an interest to add a new API to > support parsing IP address into sockaddr. Here is the proposed > signature

[API PROPOSAL] TSIpAddrParse

2017-09-13 Thread Shu Kit Chan
Hi all, I would like to see if there is an interest to add a new API to support parsing IP address into sockaddr. Here is the proposed signature. TSReturnCode TSIpAddrParse(const char *str, size_t str_len, sockaddr *addr) This is going to be largely leveraging ats_ip_parse() and ats_ip_pton() in