will open connections to
origins when receiving slow post and will consume resource of the downstream
servers.
Wondering how do other teams deal with slow-post. Is there some solution
already can handle it?
Zizhong Zhang
Software Engineer
Traffic Infrastructure
[id:image001.png@01D304CB.AA6B5770
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/692
Thanks @bgaff, @zwoop . All right. I'll change it back to set-cookie.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/692
The original name for this operator is exactly set-cookie. However, Brain
was worried about the name could be confusing with **set-cookie** in HTTP
headers.
---
If your project is set up
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/692
Thanks for the instructive comments. I've fixed most of them. For the
namespace, I would keep it as it makes code clearer.
About supporting **Set-Cookie**, let me address it with an
Github user zizhong commented on the issue:
https://github.com/apache/trafficserver/pull/692
hey @zwoop , how is the code review going? is there any issue I need to
address?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/692
[TS-4500] add cookie-rewrite functionality into header-rewrite plugin
add cookie-rewrite functionality into header-rewrite plugin.
There're three cookie handling operators
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-219270341
@zwoop , I noticed the code has been merged while this request is still
open.
About the clang-format failure, I checked the URL above and couldn't find
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/596
TS-3922: Websocket Timeouts, transaction overrideable
Websocket Timeouts, transaction overrideable(see TS-3922).
You can merge this pull request into a Git repository by running:
$ git
Github user zizhong commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/590#discussion_r6052
--- Diff: iocore/net/UnixNet.cc ---
@@ -96,8 +97,8 @@ class InactivityCop : public Continuation
NET_SUM_DYN_STAT
Github user zizhong commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/586#discussion_r60520786
--- Diff: doc/admin-guide/plugins/escalate.en.rst ---
@@ -61,4 +61,4 @@ With this line in :file:`remap.config` ::
Traffic Server would accept a
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/590
Add independent WebSocket timeouts
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zizhong/trafficserver websocket_timout
Alternatively
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/586#issuecomment-212553694
Thanks @JamesPeach for reminding me.
traffic_via and docs are updated.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/587
removing a bad comma
removing a bad comma
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zizhong/trafficserver bad_comma
Alternatively
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/586
Add VIA_ERROR_MOVED_TEMPORARILY
add VIA_ERROR_MOVED_TEMPORARILY to deal with redirect by remapping
correctly for instrumentation (logging, metrics)
You can merge this pull request into a
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-164656248
@jpeach , I noticed you have changed the some details of the last commit.
Thanks for your help. However, there is a bug that you introduced with the
changes
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-164642165
@jpeach Thanks for the useful comments. I've made a new commit on your
suggestions. Would you mind having another look?
---
If your project is set up f
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-164354432
@jpeach , the option is added in the last commit as you asked. Please let
me know if you have any questions.
cc @bgaff
---
If your project is set up
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-161340071
@jpeach you are right. Coping SSL related files can cause secure issues. In
my opinion, all the child files should not be copied. what do you think
handling it
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-159461198
@jpeach ,Sorry! You can see the lastest version of patch in this pull
request. I updated this old request rather than making a new one.
---
If your project is
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-159192050
@jpeach , after I rewrote the whole patch on your idea, I found it way more
clear and concise than before. Thank you for your great suggestions.
Let me know
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-158775453
@jpeach Thanks for your reply.
When I said the marshaling APIs being unsuitable, I meant using the APIs
marshalling the Vec(which is configFileGroup
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-158368954
@jpeach I made another pull request with your helpful commits.
About the marshalling using APIs from MgmtMarshall, the marshalling API
uses va_lists which is
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-157628406
Thanks @jpeach for the helpful comments.
For the protocol you suggested,
1. How to clean up the old watched children files correctly?
2. In a parent
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-156361172
hey @jpeach , I updated the branch with your opinion. Would you mind taking
another look at it?
---
If your project is set up for it, you can reply to this
GitHub user zizhong reopened a pull request:
https://github.com/apache/trafficserver/pull/301
TS-3960: traffic_line -x doesn't reload SSL certs content
traffic_line -x doesn't reload when SSL certs change file contents without
changing the file names.
You can merge
Github user zizhong closed the pull request at:
https://github.com/apache/trafficserver/pull/301
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/301#issuecomment-150896275
Thanks @jpeach for the comment. I'll consider about another way to handle
this.
---
If your project is set up for it, you can reply to this email and have
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/301
TS-3960: traffic_line -x doesn't reload SSL certs content
traffic_line -x doesn't reload when SSL certs change file contents without
changing the file names.
You can merge
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/271#issuecomment-128524834
great points. Actually this patch will send the content length. The content
length modified is only in the Http State structure but not in the real
HDRs
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/271
TS-3828: HEAD requests hang when origin returns Transfer-Encoding: Chunked
When a client makes a HEAD request and the origin returns a header
containing Transfer-Encoding: chunked or Content
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-125850171
Thanks for the useful information. I updated the pull request. Now it would
not crash when it doesn't have a DNS resolver. Looking forward to new feed
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/262
TS-3792: Crash with non-existant or missing resolve_conf
Fix the bug issue TS-3792: Pointing proxy.config.dns.resolv_conf at an
empty (or nonexistant) file causes segmentation faults on
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/258
TS-3780: Custom log add incoming interface ip
Extending the custom log fields to support incoming server (interface) ip.
You can merge this pull request into a Git repository by running
GitHub user zizhong opened a pull request:
https://github.com/apache/trafficserver/pull/257
Body factory
Extending body factory to support per-host error pages.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zizhong
34 matches
Mail list logo
