TS-2197 review

2013-10-08 Thread weijin
I think maybe the current code have two problems: 1. if the ua_buffer_reader is not empty (for keepalive or pipeline), the instance of http_sm may be deleted before state_read_client_request_header return. When http_tunnel callbacked with the VC_EVENT_ERROR, httpsm will delete itself if

Re: VolInit change for linux AIO

2013-04-13 Thread weijin
On 04/13/2013 07:27 AM, James Peach wrote: On Apr 11, 2013, at 7:25 PM, weijin wrote: after changed to Linux Native AIO, the AIO callback happened in the same thread, that means all subsequent operations of vol init will be also happened in only one thread. Why is this? Is it due to the

Re: VolInit change for linux AIO

2013-04-11 Thread weijin
. On 04/11/2013 11:28 PM, James Peach wrote: Hi Weijin, I'm looking at the Linux AOI changes, and there is one place where you lift the Vol::init out into a VolInit continuation. This change doesn't seem specific to Linux AIO ... can you explain why it's being done? Is it saf

Re: [1/3] git commit: Fix bug with 128 bit compare and swap.

2013-03-21 Thread weijin
well done, John. should we also changed ink_queue_load_64 to void ink_queue_load_64(void *dst, void *src) { #if (defined(__i386__) || defined(__arm__)) && (SIZEOF_VOIDP == 4) __sync_fetch_and_add((int64_t*)&(src), 0) #else *(void**)dst = *(void**)src; #endif } If not, could you please explai