[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...

2016-02-09 Thread sc0ttbeardsley
Github user sc0ttbeardsley commented on the pull request: https://github.com/apache/trafficserver/pull/459#issuecomment-182104126 @mlibbey it is a global plugin. @dmorilha we should add a "how to configure and use" section in the readme. I'll send you a PR if I get a

[GitHub] trafficserver pull request: TS-4132 Open source Yahoo's ats-inline...

2016-02-09 Thread sc0ttbeardsley
Github user sc0ttbeardsley commented on the pull request: https://github.com/apache/trafficserver/pull/459#issuecomment-182003287 @dmorilha ya, looks pretty good. We should add some details about adding the remaps for image asset urls since that is a bit tricky. Also we should add in

[GitHub] trafficserver pull request: adding TS_EVENT_HTTP_PRE_REMAP

2016-02-02 Thread sc0ttbeardsley
GitHub user sc0ttbeardsley opened a pull request: https://github.com/apache/trafficserver/pull/452 adding TS_EVENT_HTTP_PRE_REMAP Noticed this event wasn't listed here... You can merge this pull request into a Git repository by running: $ git pull https://githu

[GitHub] trafficserver pull request: TSHttpTxnHookAdd() should use txnp not...

2016-01-26 Thread sc0ttbeardsley
Github user sc0ttbeardsley commented on the pull request: https://github.com/apache/trafficserver/pull/438#issuecomment-175079288 I can haz a merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request: TSHttpTxnHookAdd() should use txnp not...

2016-01-25 Thread sc0ttbeardsley
GitHub user sc0ttbeardsley opened a pull request: https://github.com/apache/trafficserver/pull/438 TSHttpTxnHookAdd() should use txnp not ssnp I believe this is a typo You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] trafficserver pull request: [TS-3211] Add support for modifying th...

2015-03-09 Thread sc0ttbeardsley
Github user sc0ttbeardsley commented on the pull request: https://github.com/apache/trafficserver/pull/152#issuecomment-77976924 Thx guys. As long as it got done I am happy :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver pull request: [TS-3211] Add support for modifying th...

2014-11-25 Thread sc0ttbeardsley
GitHub user sc0ttbeardsley opened a pull request: https://github.com/apache/trafficserver/pull/152 [TS-3211] Add support for modifying the SCHEME via header_rewrite I need a way to rewrite the destination scheme based on a request header. It looks like it was partially added before

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2014-10-23 Thread sc0ttbeardsley
Github user sc0ttbeardsley commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-60270408 We should probably track this as a jira item... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] trafficserver pull request: Added SSL related fields to access.log

2014-10-15 Thread sc0ttbeardsley
Github user sc0ttbeardsley commented on the pull request: https://github.com/apache/trafficserver/pull/122#issuecomment-59230086 How will SPDY-enabled connections be logged? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request: Remove reference to PARAMS

2014-08-12 Thread sc0ttbeardsley
GitHub user sc0ttbeardsley opened a pull request: https://github.com/apache/trafficserver/pull/102 Remove reference to PARAMS PARAMS doesn't appear to be implemented... removing it from the docs. Was it replaced by QUERY? You can merge this pull request into a Git reposito

[GitHub] trafficserver pull request: set-redirect corrections

2014-07-23 Thread sc0ttbeardsley
GitHub user sc0ttbeardsley opened a pull request: https://github.com/apache/trafficserver/pull/98 set-redirect corrections set-redirect requires two params status-code and destination. Also QSA appears to be a supported operator flag You can merge this pull request into a Git