Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/408#issuecomment-218546235
I have to write an example test using the mocks. Let me use webp_transform
and write a test.
---
If your project is set up for it, you can reply to this email
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/494#issuecomment-187401027
:+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186383393
@zwoop @shukitchan made changes as suggested.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-186013102
@bgaff can you review now. Using ImageMagick makes the code much cleaner.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/442#issuecomment-179556404
Closing the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user myraid closed the pull request at:
https://github.com/apache/trafficserver/pull/442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/442#issuecomment-177009174
we would not know which object to reset.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/442#issuecomment-176964528
updated the request/response objects to reset the handles to null n failure.
@sudheerv can you review.
---
If your project is set up for it, you can reply to
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/443#issuecomment-176522121
:+1: Need to make sure this goes along with #442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user myraid opened a pull request:
https://github.com/apache/trafficserver/pull/442
[TS-4135] fix redirect coredump
@bgaff @shukitchan @sudheerv can you review.
Removing TSMlocRelease is harmless as it s a no-op. Until we come up with a
better way of cleanup lets not
GitHub user myraid opened a pull request:
https://github.com/apache/trafficserver/pull/408
[TS-4103] mocks
@bgaff Can you review.
This one works. Is there a better approach?
You can merge this pull request into a Git repository by running:
$ git pull https
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-168846815
@bgaff I reused some of the code from libwebp examples and so there is a
mix of C and C++. I will check if Imagemagick can be used to abstract image
specific
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167855489
@shukitchan done with c-lang formating.
@mlibbey good idea to have a remap plugin. Will work on it once this PR is
merged.
---
If your project is set up for
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167018043
What should the document consist? The design of the plugin ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-167011245
refactored the code to follow naming conventions as suggested by
@shukitchan .
please review.
---
If your project is set up for it, you can reply to
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-166764391
@bgaff I made the suggested changes. Also added license agreement.
@shukitchan I am working on c-lang formatting and update the PR.
---
If your
Github user myraid commented on the pull request:
https://github.com/apache/trafficserver/pull/393#issuecomment-166471944
@shukitchan we could easily move it to experimental. Probably have to check
additional flags in Makefile.am under experimental.
Once @bgaff is Ok I can work on
GitHub user myraid opened a pull request:
https://github.com/apache/trafficserver/pull/393
[TS-4095] adding a new example plugin for converting jpeg/png to webpâ¦
@shukitchan @bgaff can you review and merge the PR.
You can merge this pull request into a Git repository by running
GitHub user myraid opened a pull request:
https://github.com/apache/trafficserver/pull/378
[TS-4091] support for esi variables using request headers
@shukitchan can you take care of reviewing and merging the PR.
JIRA opened for this PR.
https://issues.apache.org/jira
19 matches
Mail list logo
