Github user dragon512 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/780#discussion_r69330409
--- Diff: proxy/http/HttpSessionManager.cc ---
@@ -55,9 +55,10 @@ ServerSessionPool::ServerSessionPool() :
Continuation(new_ProxyMutex()), m_ip_po
Github user dragon512 commented on the issue:
https://github.com/apache/trafficserver/pull/679
The only concern i would have with .aux is that it hides files, and if you
don't know that you should look for them, it can be hard to find them when
trying to solve some probl
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/679
Honestly I would use _aux myself. Allen said somebody hates _ so i made it
ts_aux. honestly it does not matter it just cannot be prn, aux, or con
It is useful for "gene
Github user dragon512 commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/679#discussion_r65234405
--- Diff: configure.ac ---
@@ -37,7 +37,7 @@ m4_define([TS_VERSION_N],[700])
AC_INIT([Apache Traffic Server], TS_VERSION_S(),
[dev
GitHub user dragon512 opened a pull request:
https://github.com/apache/trafficserver/pull/679
Update configure.ac
Change "aux" directory to a value that does not upset systems that use this
value as a device name for legacy purposes
You can merge this pull request
GitHub user dragon512 opened a pull request:
https://github.com/apache/trafficserver/pull/650
TS-4450: Syntax error in CI test
Fix extra ) that was in the list
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dragon512
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/622#issuecomment-217931548
no wait.. I missed it the code it is there . This looks fine
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/622#issuecomment-217930908
Given what I can see everything looks correct in the allocate code. The
only concern I have is that the rebind function can be inherited correctly as
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/556#issuecomment-208934704
Sure, I think the point of the namespace it to define a concept or domain.
This makes it easy to deal with class with the same name in different
namespaces
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/556#issuecomment-208902197
Why do you want to avoid namespaces? They are a good thing
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/556#issuecomment-207522902
Looks good to me. However can we use namespaces? I mean
ts_stl_iobuf_allocator!!
it would better in my view to have
namespace ts
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/497#issuecomment-188374276
The other question I would have is why would we not want -fPie enable for
any compiler that supports it.
---
If your project is set up for it, you can reply
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/497#issuecomment-188371373
The sed command seems hacky to me. It would be clearer if we have a
SHCXXFLAGS, etc ( ie Shared library flags or we can do the other way and make a
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-187311382
I take back what I said after talking to Bryan call.. This is using a
openssl lib callback API. So this looks good. The CPU is going to fine as long
as we are
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-187217377
I am not sure why we are using C++ and not using new to do this? We want to
track memory in Traffic server that is being used to alloc memory for OpenSSL (
ie
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/440#issuecomment-176508745
I agree with James in that the test are badly written. A better fix would
be to use a real testing system. I working on that as well. It would be worse
just to
Github user dragon512 commented on the pull request:
https://github.com/apache/trafficserver/pull/440#issuecomment-176292994
Thanks. I have updated the patch with this fix
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user dragon512 opened a pull request:
https://github.com/apache/trafficserver/pull/440
[TS-4157] traffic_via tests use bad characters in the file name
Changed the usage of : to ; which seems to be more filename friendly.
Changed test files to have ; in them
You can merge
GitHub user dragon512 opened a pull request:
https://github.com/apache/trafficserver/pull/313
Fix issue with TS-3885. Changes to TSNetVConn test to prevent it fromâ¦
⦠hanging when the defer_accept is set ( via config or kernel option)
You can merge this pull request into a Git
19 matches
Mail list logo
