GitHub user canselcik opened a pull request:
https://github.com/apache/trafficserver/pull/349
TS-4040: Adding the missing `va_end(...)` statements to `Diags.cc` and
`wccp-test-router.cc`
Adding the needed va_end(...) statements.
@bgaff
You can merge this pull
GitHub user canselcik opened a pull request:
https://github.com/apache/trafficserver/pull/348
TS-4039: StreamHashTable::deleteStaleStreams doesn't initialize an int
primitive to zero before iterating
Properly initializing the `int i` to `0` in
`StreamHashTable::deleteStaleSt
GitHub user canselcik opened a pull request:
https://github.com/apache/trafficserver/pull/347
TS-4038: Redundant `isdigit(b)` in `LogFormat::parse_escape_string
Simple fix that shouldn't have any side effects since isdigit is not
changing the value of b.
@bgaff
Yo
Github user canselcik closed the pull request at:
https://github.com/apache/trafficserver/pull/344
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user canselcik commented on the pull request:
https://github.com/apache/trafficserver/pull/344#issuecomment-158515997
Sounds good.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user canselcik opened a pull request:
https://github.com/apache/trafficserver/pull/344
Refactoring of atscppapi code
@bgaff
Removing `CaseInsensitiveStringComparator` class from `atscppapi` as it can
be replaced with and is not used in the codebase at all
GitHub user canselcik opened a pull request:
https://github.com/apache/trafficserver/pull/340
Memory leak in Rule::socksParse(char*) if a token is missing the '=' sign
Memory is allocated at line 585 with `TokenList *m_tokenList = new
TokenList()` but reference to it is
Github user canselcik commented on the pull request:
https://github.com/apache/trafficserver/pull/323#issuecomment-154269760
Thanks for the merge, and sounds good, I will look into removing the
destructors in the SPDY code and improvements to `ClassAllocator` later today.
---
If
Github user canselcik commented on the pull request:
https://github.com/apache/trafficserver/pull/323#issuecomment-154213497
Sounds good. So why don't we move forward with this PR as is, and add the
```
void SpdyClientSession::clear()
{
if (!mutex)
r
Github user canselcik commented on the pull request:
https://github.com/apache/trafficserver/pull/323#issuecomment-153974633
How about `ClassAllocator spdyRequestAllocator`, though? If
the right fix is to remove `~SpdyClientSession()`, then should we also remove
`~SpdyRequest
Github user canselcik commented on the pull request:
https://github.com/apache/trafficserver/pull/323#issuecomment-153954924
Upon exit `static ClassAllocator
spdyClientSessionAllocator` goes out of scope and its destructor is called,
which goes on to call the destructor on the
Github user canselcik commented on the pull request:
https://github.com/apache/trafficserver/pull/323#issuecomment-153950655
@jpeach `ClassAllocator`, when initialized, creates an
instance of `SpdyClientSession` and puts it aside. At this point, for this
"prot
GitHub user canselcik opened a pull request:
https://github.com/apache/trafficserver/pull/323
Dereferencing a NULL pointer in SpdyClientSession::clear()
- At `SpdyClientSession.cc:28`, `static ClassAllocator
spdyClientSessionAllocator` creates an instance of `SpdyClientSession
13 matches
Mail list logo
