Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/790
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/749
It should be conditional on the 304 in the build_error_response and also
added to build_response. Maybe pull the logic into a method and call it from
both.
---
If your project is set up
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/749#discussion_r69032683
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8199,13 +8199,15 @@ HttpTransact::build_error_response(State *s,
HTTPStatus status_code, const char
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/749#discussion_r69032591
--- Diff: proxy/http/HttpTransact.cc ---
@@ -8199,13 +8199,15 @@ HttpTransact::build_error_response(State *s,
HTTPStatus status_code, const char
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/733
ð Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/760
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/760#discussion_r68882501
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1054,7 +1055,7 @@ Http2ConnectionState::send_a_data_frame(Http2Stream
*stream, size_t
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/760
TS-4542: ASAN error with HTTP/2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4542
Alternatively you can
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/751
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/751
TS-4542: ASAN error with HTTP/2 priority
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4542
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/746
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/746
TS-4512: Error when building with gcc 6.1.1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4512
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/730
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/731
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/731
TS-4569: New Coverity issues found in updated scan
Fixed issues: 1356977
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/730
TS-4569: New Coverity issues found in updated scan
Fixed issues: 1356980 and 1356979
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/727
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/729
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/726
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall commented on the issue:
https://github.com/apache/trafficserver/pull/728
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/729
TS-4569: New Coverity issues found in updated scan
Fixed issues: 1356981 and 1356983
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/726
TS-4569: New Coverity issues found in updated scan
Fixes for issues: 1356985, 1356984, and 1356982
You can merge this pull request into a Git repository by running:
$ git pull https
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/725
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/725
TS-4568: Milestones where changed from seconds to milliseconds
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/724
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/724
TS-4470: ASAN stack-buffer-overflow when slow log is enabled
Update to use offset too
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/721#discussion_r67789890
--- Diff: proxy/http/HttpSM.cc ---
@@ -6890,7 +6890,8 @@ HttpSM::update_stats()
int offset = 0;
int skip = 0
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/721
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/721
TS-4470: ASAN stack-buffer-overflow when slow log is enabled
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/711
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/716
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/716
TS-4545: Tools do not build cleanly on OmniOS
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4545
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/711
TS-4527: Removing unneeded do_io_read and do_io_write that were causeâ¦
⦠error
messages to be logged
You can merge this pull request into a Git repository by running
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/669#discussion_r64785961
--- Diff: proxy/http/Http1ClientSession.cc ---
@@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction
*trans)
ka_vio
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/668
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/667
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/668
TS-4367: Failed clang-analyzer, memory leak in mgmt/api
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver clang2
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/667
Clang-analyzer failure, Called C++ object pointer is null
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/662
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/662#issuecomment-221350082
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/660
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/660#issuecomment-221124146
ð - looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63748572
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -906,74 +957,140 @@
Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63740460
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -906,74 +957,140 @@
Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63740371
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -906,74 +957,140 @@
Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63739375
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -906,74 +957,140 @@
Http2ConnectionState::update_initial_rwnd(Http2WindowSize new_size
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/630
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63251327
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -238,22 +241,29 @@ rcv_headers_frame(Http2ConnectionState &cstate, const
Http2Frame &a
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/632#discussion_r63248097
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -238,22 +241,29 @@ rcv_headers_frame(Http2ConnectionState &cstate, const
Http2Frame &a
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/630#issuecomment-219152242
ð - Looked pretty straight forward and didn't break working with OpenSSL
1.0.2.
---
If your project is set up for it, you can reply to this email and
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/625#issuecomment-218203477
How are you seeing the double free? The original code looks good.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bryancall closed the pull request at:
https://github.com/apache/trafficserver/pull/621
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/621
TS-4427: traffic_logstats: Count TCP_MEM_HIT as a "normal" hit
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/tra
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-217023707
Besides the formatting it looks good. I was meaning from above that you
would have to check the allowed methods at the at the session level. I missed
the
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-217020754
Looks like it needs to be clang-formatted there are a few formatting issues.
---
If your project is set up for it, you can reply to this email and have your
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/614#discussion_r62123967
--- Diff: proxy/http2/Http2SessionAccept.cc ---
@@ -38,19 +39,25 @@ Http2SessionAccept::~Http2SessionAccept()
void
Http2SessionAccept
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-216920012
Don't you need to check what is being denied at the higher level?
---
If your project is set up for it, you can reply to this email and have your
reply a
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/614#issuecomment-216916522
Where is the check on the method? Each individual stream would need to be
verified.
---
If your project is set up for it, you can reply to this email and
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214469357
@jacksontj Having it part of the existing metrics would mean you would have
a metric per origin. We went down that road before and created a stats v2
which
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214452145
It is configurable to turn it off and on.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/598#issuecomment-214451166
@zwoop This is a value per origin, not a single number that can be
represented in the metrics/stats.
I agree, having something that can generically log
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/536#issuecomment-27557
Have you tested this change in production?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/556#issuecomment-207463328
I agree with @zwoop, we have turned off spdy in prod and would rather see
this in h2.
---
If your project is set up for it, you can reply to this email and
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205308868
See e83b131b and TS-3049 for why the Connection: close logic was added.
https://issues.apache.org/jira/browse/TS-3049
---
If your project is set up
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/549#issuecomment-205305115
Seems odd that having a method named FetchSM::has_body() is doing checks
on if the Connection: close header is there. The logic on the close header
should be
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r57029193
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/460#issuecomment-199522681
Overall it looks good. I had a couple comments in the code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56910134
--- Diff: proxy/http2/HTTP2.cc ---
@@ -484,246 +498,175 @@ convert_from_2_to_1_1_header(HTTPHdr *headers)
return PARSE_DONE
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56909414
--- Diff: proxy/http2/HPACK.h ---
@@ -90,31 +97,29 @@ class MIMEFieldWrapper
return _field;
}
+ bool
+ is_sensitive
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/460#discussion_r56908946
--- Diff: proxy/http2/HPACK.cc ---
@@ -828,9 +828,111 @@ update_dynamic_table_size(const uint8_t *buf_start,
const uint8_t *buf_end, Http
if
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/485#issuecomment-198585206
How would this prevent a DDOS attack if clients established a bunch of
connections and then made requests up to the max number of streams per
connection (100
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/522
TS-4267: HTTP/2 Updates to debugging
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4267
Alternatively
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/518
TS-4253: Better debug messages in ssl_read_from_net()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS-4253
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/485#discussion_r54014800
--- Diff: proxy/http2/Http2ConnectionState.cc ---
@@ -1160,3 +1162,31 @@
Http2ConnectionState::send_window_update_frame(Http2StreamId id, uint32_t
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/497#issuecomment-188403390
@jpeach
Do you foresee any issues with doing a double hardening (distributions
doing it and having it on by default)?
---
If your project is set up for
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/497#issuecomment-188402711
@dragon512
One benefit of doing the sed at the end of the process is that the FLAGS
are in sync. Adding addition variables would require that we don&#
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/497#issuecomment-188399695
I updated to remove `-fno-omit-frame-pointer`.
@dragon512
Most distributions do hardening themselves. I think it would be better
have an option
GitHub user bryancall opened a pull request:
https://github.com/apache/trafficserver/pull/497
TS-3938: Add hardening (fortify) as an option to configure
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bryancall/trafficserver TS
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-187939855
Updated to look for malloc_usable_size in autoconf and #ifdef for support.
---
If your project is set up for it, you can reply to this email and have your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/492#issuecomment-187827581
Same pull request as #493
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/493#issuecomment-187827716
Same pull request as #492
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/490#issuecomment-187827174
@jpeach will shepard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/489#issuecomment-187826715
@PSUdaemon said there is FreeBSD support for malloc_usable_size(), but not
for OmniOS.
Need to #ifdef for OmniOS.
---
If your project is set up for
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/460#issuecomment-187824312
I will take a look at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/485#issuecomment-187823737
I will take a look at this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/488#issuecomment-187824115
@zwoop will shepard.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/424#issuecomment-187822841
@jrushf1239k Please address the concerns and update the pull request.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/408#issuecomment-187822028
@bgaff can you shepard this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/407#issuecomment-187821803
Talking at the github meeting. The consensus is that we should split the
pull request into two pull requests. One for multi origin and the other for
retry
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/373#issuecomment-187818356
@shinrich is going to shepard this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/374#issuecomment-187818415
@shinrich is going to shepard this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/351#issuecomment-187818009
Talking at the github meeting. We should have a maximum size that will be
buffered in memory. This should go through API review. Please provide
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/343#issuecomment-187814680
@SolidWallOfCode and @dragon512 are going to take ownership of this.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/330#issuecomment-187811485
We talked about this at the github meeting. As a workaround you can adjust
the Last-Modified with header rewrite. We feel this is the best solution to
only
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/309#issuecomment-187805696
@ftarnell Can you please rebase this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/308#issuecomment-187805341
Please close and moving this over to #309
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/304#issuecomment-187804291
This needs to be investigated more to completely solve this issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/272#issuecomment-187800809
@SolidWallOfCode said he would work on it this quarter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/210#issuecomment-187799694
@oschaaf can you please work on this and get it committed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user bryancall commented on the pull request:
https://github.com/apache/trafficserver/pull/228#issuecomment-187799137
This pull request is for https://issues.apache.org/jira/browse/TS-3407
---
If your project is set up for it, you can reply to this email and have your
reply
1 - 100 of 192 matches
Mail list logo
