Re: [E] Modified and New TS APIs Proposal

2021-07-29 Thread Jeff Elsloo
I just pushed a commit that implements option 2 above because I felt that it was a more straightforward approach that can be easily documented (and is). The alternate approach of `memcpy`ing a static instance, while simple on the surface, seems a little too in the weeds for an API caller that may n

Re: [E] Modified and New TS APIs Proposal

2021-07-28 Thread Jeff Elsloo
r a size value, or > both, so that backwards compatibility can be maintained. > > On Tue, Jul 27, 2021 at 3:59 PM Jeff Elsloo wrote: > > > Hi Alan, > > > > I modified the function I introduced to take an options struct as its > > single argument to reduce the clu

Re: [E] Modified and New TS APIs Proposal

2021-07-27 Thread Jeff Elsloo
Hi Alan, I modified the function I introduced to take an options struct as its single argument to reduce the clutter. I added the fields necessary to support my work in PR #8088 and will update #8089 if the changes in the former are accepted. I did not add a field for transparency as you mentioned

Modified and New TS APIs Proposal

2021-07-26 Thread Jeff Elsloo
Hi all, I'd like to introduce a change to an existing API that leads to a new function signature and add two new related convenience functions that enable plugins. This change enables control of buffer sizes and watermarks used with IOBuffers between the plugin and the core, which is implemented t

Re: [E] New TS API Proposal: TSHttpTxnCacheDiskPathGet

2021-05-07 Thread Jeff Elsloo
May 6, 2021 at 11:42 AM Jeff Elsloo wrote: > > I just pushed a commit that incorporates this feedback and updated the > dependent PR that enhances the xdebug plugin to reflect the change. > The diff is as follows: > > – tsapi TSReturnCode TSHttpTxnCacheDiskPathGet(TSHttpTxn tx

Re: [E] New TS API Proposal: TSHttpTxnCacheDiskPathGet

2021-05-06 Thread Jeff Elsloo
API, the signature should be arranged to return a view. E.g. > > const char * TSHttpTxnCacheDiskPathGet(TSHttpTxn txn, int * length); > > This is modeled on API calls such as TSHttpHdrHostGet, > TSHttpTxnPluginTagGet, and the family of TSUrlHostGet etc. > > > > On Tue, May 4

New TS API Proposal: TSHttpTxnCacheDiskPathGet

2021-05-04 Thread Jeff Elsloo
Hi all, I'd like to propose the introduction of a new TS API, TSHttpTxnCacheDiskPathGet. The function signature is as follows: tsapi TSReturnCode TSHttpTxnCacheDiskPathGet(TSHttpTxn txnp, const char **path); The intent of this API is to expose the underlying disk used to service a request, regar