[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68602422 --- Diff: iocore/hostdb/HostDB.cc --- @@ -300,131 +237,77 @@ HostDBProcessor::cache() return &hostDB; } -struct HostDBTe

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68601782 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68601646 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68601432 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68601178 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68600648 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68600442 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68599767 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68599511 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

Github user JamesPeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r68599043 --- Diff: iocore/hostdb/P_RefCountCache.h --- @@ -0,0 +1,896 @@ +/** @file + + A cache (with map-esque interface) for RefCountObjs

[GitHub] trafficserver pull request: TS-4388: Fix TSHttpTxnParentProxySet

Github user JamesPeach commented on the pull request: https://github.com/apache/trafficserver/pull/606#issuecomment-215581577 The 99% case in the code is ``parent_result.result`` which didn't seem too bad to me. I hated, hated, hated ``parent_result.r`` ;) --- If your project i

[GitHub] trafficserver pull request: TS-4180: Support for multiple intermed...

Github user JamesPeach commented on the pull request: https://github.com/apache/trafficserver/pull/578#issuecomment-215151224 So this patch skips the only test we have for this stuff? --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] trafficserver pull request: TS-4328

Github user JamesPeach commented on the pull request: https://github.com/apache/trafficserver/pull/554#issuecomment-214490389 As per IRC discussion with @zwoop and @bryancall, I think we should find a way to not use the milestones to track the state transition. --- If your project

[GitHub] trafficserver pull request: [TS-4379] Add log field for Server Con...

Github user JamesPeach commented on the pull request: https://github.com/apache/trafficserver/pull/598#issuecomment-214464758 A log field to mark whether a server session was re-used seems helpful, but a very different patch from what is being proposed here. --- If your project is

[GitHub] trafficserver pull request: [TS-4379] Add log field for Server Con...

Github user JamesPeach commented on the pull request: https://github.com/apache/trafficserver/pull/598#issuecomment-214463141 @bryancall AFAICT ``server_connection_count`` is always populated, which is hitting a global lock. If there's no consensus that this is the right app

[GitHub] trafficserver pull request: Add VIA_ERROR_MOVED_TEMPORARILY

Github user JamesPeach commented on the pull request: https://github.com/apache/trafficserver/pull/586#issuecomment-212182075 Please update ``traffic_via`` and any other places that document or reference the Via string. --- If your project is set up for it, you can reply to this