RE: Lua plugin assertion failure question.

2022-07-06 Thread CHOU, PETER
/apache/trafficserver/pull/8607__;!!BhdT!lFEKdtxbGBnhcNPCzFPi2u3EzgDOmNN3xGseGw7u7EP6beRGjrNIyDInP4VMtptmCMGtD5cDzstdxXXjFA$ That should essentially be doing what you want for server request pointers as well. Can you try this out? On Tue, Jun 28, 2022 at 2:16 PM CHOU, PETER wrote: > > Kit, &g

RE: Lua plugin assertion failure question.

2022-06-28 Thread CHOU, PETER
g the coredump problem. I believe that it should not be too much of a problem in terms of efficiency. Thanks. Kit On Wed, Jun 17, 2020 at 5:11 PM Chou, Peter wrote: > > Hi All, > > We recently experienced a bunch of assertion failures with the Lua plugin on > ATS 7.1.4. When the transac

RE: Question on Lua plugin differences between ATS 7.1.x and ATS 9.x.

2022-03-14 Thread CHOU, PETER
lector reports = " .. collectgarbage("count") .. " MB") end function do_remap() ts.debug("Running do_remap()...") end -Original Message- From: CHOU, PETER Sent: Monday, March 14, 2022 10:29 AM To: dev@trafficserver.apache.org; us...@trafficse

RE: Question on Lua plugin differences between ATS 7.1.x and ATS 9.x.

2022-03-14 Thread CHOU, PETER
Lua plugin differences between ATS 7.1.x and ATS 9.x. Is this a lua script you in plugin.config or remap.config ? Also what method do you use to see if gc is happening or not ? On Fri, Mar 11, 2022 at 1:22 PM CHOU, PETER wrote: > > Hi, > > > > We have quite a few Lua scripts th

Question on Lua plugin differences between ATS 7.1.x and ATS 9.x.

2022-03-11 Thread CHOU, PETER
Hi, We have quite a few Lua scripts that were written for use with ATS 7.1.4 and earlier. We are looking to migrate to ATS 9.1.1, but it seems like the garbage collection that is supposed to happen during a "traffic_ctl config reload" (reload a remap configuration file containing remap lines us

Open an issue for --enable-debug binaries?

2022-01-24 Thread CHOU, PETER
Hi, Should I open an issue for a fault, such as an assertion failure, that only happens with binaries compiled with the '-enable-debug' option? I thought this just affected the compiler optimization options, but perhaps something logically is being changed? Although I usually only use this opt

Which release of LuaJIT should we use with the ATS lua plugin?

2021-11-09 Thread CHOU, PETER
Hi All, Apologies if this is a duplicate message for anyone. I had to re-subscribe and re-send as my company had changed my e-mail address. We are currently working with ATS 9.0.2. Since the LuaJIT source is no longer included with the ATS source tree, we have tried using - 1. Default v2.1

RE: Question about Consistent Hash and parent retry

2021-08-17 Thread CHOU, PETER
Hi, There is no background thread checking on the original parent. Once the original parent is marked down, the parent selection process will ignore it until it becomes retryable after a time-out period. This is configurable using the "proxy.config.http.parent_proxy.retry_time" setting. Thanks,

Is there a performance issue with --enable-debug binaries?

2021-04-20 Thread Chou, Peter
Hi, I know there was some discussion on the bug scrub (last week I think) that enabling debug output in the records.config on any debug tags will greatly reduce performance. Is it also the case that using a binary compiled with '-enable-debug' will also cause performance issues? Thanks, Peter

RE: Help with plugin loading in ATS 7.1.x vs ATS 9.0.x.

2021-03-19 Thread Chou, Peter
OK, I found the "CONFIG proxy.config.plugin.dynamic_reload_mode INT 0" to disable this new feature. After I already modified my plugin ... :-) From: Chou, Peter Sent: Friday, March 19, 2021 2:02 PM To: dev@trafficserver.apache.org Subject: Help with plugin loading in ATS 7.1.x vs ATS

Help with plugin loading in ATS 7.1.x vs ATS 9.0.x.

2021-03-19 Thread Chou, Peter
Hi, I have a plugin under ATS 7.1.x that performed initialization under the global plugin context. This initialized data used to be available to the remap contexts of the same plugin. I assume that the new remap plugin reloading capability in 9.0.0 means that this no long works (since remap pl

RE: [VOTE] Release Apache Traffic Server 9.0.1 (RC0)

2021-03-02 Thread Chou, Peter
Regression test -R 2 passed on Ubuntu Linux 18.04 LTS -- REGRESSION_TEST DONE: PASSED Traffic Server 9.0.1 Mar 2 2021 10:35:45 piplup2 traffic_server: using root directory '/home/pebc/opt/ats-gh-9.0.x' Apache Traffic Server - traffic_server - 9.0.1 - (build # 030210 on Mar 2 2021 at 10:35:45)

RE: [UPDATED: RC1] Re: [E] [VOTE] Release Apache Traffic Server 9.0.0 (RC0)

2020-12-09 Thread Chou, Peter
Regression tests -R2 passed with Ubuntu Linux 18.04 LTS 64-bit server. Thanks. -Original Message- From: Leif Hedstrom Sent: Tuesday, December 8, 2020 10:30 AM To: users Cc: dev Subject: [UPDATED: RC1] Re: [E] [VOTE] Release Apache Traffic Server 9.0.0 (RC0) We’ll cancel the 9.0.0-RC0

RE: [VOTE] Release Apache Traffic Server 8.1.1 (RC0)

2020-12-01 Thread Chou, Peter
+1 for Ubuntu Linux 18.04 LTS 64-bit server with -R2. From: Bryan Call Sent: Tuesday, December 1, 2020 1:21 PM To: annou...@trafficserver.apache.org; Dev ; Users Subject: [VOTE] Release Apache Traffic Server 8.1.1 (RC0) I've prepared a release for 8.1.1. The release notes for 8.1.1 are avail

RE: [VOTE] Release Apache Traffic Server 7.1.12 (RC0)

2020-12-01 Thread Chou, Peter
+1 for Ubuntu Linux 18.04 LTS 64-bit server with -R2. BTW, is there a sunset date for 7.1.x support? From: Bryan Call Sent: Tuesday, December 1, 2020 1:21 PM To: annou...@trafficserver.apache.org; Dev ; Users Subject: [VOTE] Release Apache Traffic Server 7.1.12 (RC0) I've prepared a release

RE: Problem with build with 8.1.x?

2020-09-03 Thread Chou, Peter
efine YY_FLEX_SUBMINOR_VERSION 0" was changed to "4" in the modified version of the file (among other changes). Thanks. From: Chou, Peter Sent: Wednesday, September 2, 2020 3:59 PM To: dev@trafficserver.apache.org Subject: Problem with build with 8.1.x? Hi, I noticed that after I compiled the 8

Problem with build with 8.1.x?

2020-09-02 Thread Chou, Peter
Hi, I noticed that after I compiled the 8.1.x branch that the compilation process modified a file tracked by git. This does not seem right to me? pebc@piplup2:~/git/github/apache-trafficserver$ git status On branch 8.1.x Your branch is up to date with 'origin/8.1.x'. Changes not staged for com

RE: [VOTE] Release Apache Traffic Server 8.1.0 (RC0)

2020-08-25 Thread Chou, Peter
+1 regression tests '-R 2' passed on Ubuntu Linux 18.04 LTS. -Original Message- From: Leif Hedstrom Sent: Monday, August 24, 2020 3:39 PM To: dev ; users Subject: [VOTE] Release Apache Traffic Server 8.1.0 (RC0) I've prepared a release for 8.1.0 (RC0), which is a release focusing on s

Lua plugin assertion failure question.

2020-06-17 Thread Chou, Peter
Hi All, We recently experienced a bunch of assertion failures with the Lua plugin on ATS 7.1.4. When the transaction is being killed, the Lua plugin calls ts_lua_destroy_http_ctx() which calls TSHandleMLocRelease() with http_ctx->server_request_bufp as the buffer argument. The assertion failure

RE: [VOTE] Release Apache Traffic Server 8.0.7 (RC0)

2020-04-14 Thread Chou, Peter
+1 Regression tests '-R2' passed on Ubuntu Linux 18.04 LTS. * Apache Traffic Server - traffic_server - 8.0.7 - (build # 041413 on Apr 14 2020 at 13:17:45) * Linux piplup2 4.15.0-96-generic #97-Ubuntu SMP Wed Apr 1 03:25:46 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux * REGRESSION_TEST DONE: PASSED

RE: [VOTE] Release Apache Traffic Server 7.1.10 (RC0)

2020-04-14 Thread Chou, Peter
+1 Ran regression tests '-R2' on Ubuntu Linux 18.04 LTS. Apache Traffic Server - traffic_server - 7.1.10 - (build # 041413 on Apr 14 2020 at 13:02:38) Linux piplup2 4.15.0-96-generic #97-Ubuntu SMP Wed Apr 1 03:25:46 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux REGRESSION_TEST DONE: PASSED -Ori

Question on calling TSMimeHdrFieldFind() from the Lua plugin.

2019-11-20 Thread Chou, Peter
Hi All, We experienced some core dumps in ATS 7.1.4. My question is whether the pointers returned by TSHttpTxnServerReqGet() might ever become invalid over the life of the transaction? The core dump occurred from the Lua plugin in the ts_lua_server_request_header_set() function -- if (!http_c

RE: Lua plugin memory limit on Linux.

2019-10-08 Thread Chou, Peter
LE_GC64) If it works, we should definitely document it. Thanks. Kit On Thu, Jun 20, 2019 at 1:35 PM Chou, Peter wrote: > > Kit, > > This is the only error message seen from diags.log. It did not cause the ATS > to core dump. > > [Jun 20 13:27:45.258] traffic_server NOTE: plu

RE: TCP socket buffer size.

2019-09-12 Thread Chou, Peter
d be some latency difference between having a small buffer size vs a larger one (up to some limit), but my guess is it would be hard to measure because it would be so small. -Bryan > On Sep 11, 2019, at 11:50 AM, Chou, Peter wrote: > > Hi all, > > Sometimes we see lots of EAGAIN

TCP socket buffer size.

2019-09-11 Thread Chou, Peter
Hi all, Sometimes we see lots of EAGAIN result codes from ATS trying to write to the TCP socket file descriptor. I presume this is typically due to congestion or rate mis-match between client and ATS. Is there any benefit to increasing the TCP socket buffer size which would reduce the number of

RE: Lua plugin memory limit on Linux.

2019-06-20 Thread Chou, Peter
e 19, 2019 11:32 PM To: dev Subject: Re: Lua plugin memory limit on Linux. Thanks for the info. That's good to know. Have you tried how much more you can allocate? And when you are over the limit, what is the message you are getting? Perhaps we can update the doc with this information. Kit

Lua plugin memory limit on Linux.

2019-06-19 Thread Chou, Peter
Kit, Did not hear back from you regarding the memory limit for the Lua plugin on Linux. Previously, I had tested on the command line with the luajit executable, but I have completed some testing with the ATS master branch. I am running with Ubuntu 18.04 LTS Server 64-bit which ships with 'LuaJ

RE: [VOTE] Release Apache Traffic Server 8.0.4 (RC0)

2019-06-03 Thread Chou, Peter
Ubuntu 18.04 LTS Server 64-bit Linux piplup2 4.15.0-47-generic #50-Ubuntu SMP Wed Mar 13 10:44:52 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Apache Traffic Server - traffic_server - 8.0.4 - (build # 060321 on Jun 3 2019 at 21:19:31) HEAD detached at 8.0.4-rc0 Result '-R 2' -- REGRESSION_TEST DO

RE: [VOTE] Release Apache Traffic Server 7.1.7 (RC0)

2019-06-03 Thread Chou, Peter
Regression test -R 2 passed on Ubuntu Linux 18.04 LTS Server 64-bit. REGRESSION_TEST DONE: PASSED Apache Traffic Server - traffic_server - 7.1.7 - (build # 060313 on Jun 3 2019 at 13:01:37) HEAD detached at 7.1.7-rc0 Linux piplup2 4.15.0-47-generic #50-Ubuntu SMP Wed Mar 13 10:44:52 UTC 2019 x8

RE: Questions on tslua plugin and luajit.

2019-05-01 Thread Chou, Peter
ce. Kit On Wed, May 1, 2019 at 9:09 AM Chou, Peter wrote: > > Kit, > > Thanks for the response. With regards to the LuaJIT 2.1.0-beta3, I have not > tried > using the ts_lua plugin, but with a simple test program using the luajit > command line I was able to allocate 2.0GB o

RE: Questions on tslua plugin and luajit.

2019-05-01 Thread Chou, Peter
aware that luajit-2.1.0-beta3 will have any improvement to the memory limit problem. Thanks. Kit On Tue, Apr 30, 2019 at 11:05 AM Chou, Peter wrote: > > Hi, > > Few questions on LuaJIT in relation to the ts_lua plugin. > > 1. We did get the following core dump in production.

Questions on tslua plugin and luajit.

2019-04-30 Thread Chou, Peter
Hi, Few questions on LuaJIT in relation to the ts_lua plugin. 1. We did get the following core dump in production. Does this fit the signature for a LuaJIT memory exhaust? Program terminated with signal 11, Segmentation fault. #0 0x2b67b4bfeacd in __run_exit_handlers () from /lib64/libc.so.

RE: [VOTE] Release Apache Traffic Server 8.0.3 (RC0)

2019-03-13 Thread Chou, Peter
Reporting regression tests -R 2 passed on Ubuntu Linux 18.04 LTS Server 64-bit. -Original Message- From: Bryan Call Sent: Monday, March 11, 2019 11:15 AM To: dev ; users Subject: [VOTE] Release Apache Traffic Server 8.0.3 (RC0) I've prepared a release for 8.0.3 (RC0). The release not

Branch 7.1.x issue?

2019-02-20 Thread Chou, Peter
Hi, I get an assertion fault core dump in 7.1.x HEAD from HdrHeap.cc::874. This seems to be isolated down to commit 739d8d. What I think is happening is that the copy of the content stored in the cache uses a different amount of space before and after this change when doing an un-marshal. I re-

RE: [VOTE] Release Apache Traffic Server 7.1.6 (RC1)

2019-01-23 Thread Chou, Peter
Regression test -R 2 passed on Ubuntu Linux 18.04 LTS Server. BTW, built against 7.1.x HEAD matching the git hash below. The tag did not appear to be in the GitHub repo yet. -Original Message- From: Zelkowitz, Evan Sent: Tuesday, January 22, 2019 3:54 PM To: dev ; Mailing-List trafficser

RE: [VOTE] Release Apache Traffic Server 8.0.2 (RC0)

2019-01-22 Thread Chou, Peter
Regression test -R 2 passed on Ubuntu Linux 18.04 LTS Server. -Original Message- From: Bryan Call Sent: Tuesday, January 22, 2019 12:48 PM To: dev ; users Subject: [VOTE] Release Apache Traffic Server 8.0.2 (RC0) I've prepared a release for 8.0.2 (RC0). The release notes for 8.0.2 are

RE: [VOTE] Release Apache Traffic Server 7.1.5 (RC0)

2018-11-13 Thread Chou, Peter
+1 Regression Tests passed (-R 2) on Ubuntu Linux 18.04 LTS. -Original Message- From: Leif Hedstrom Sent: Wednesday, November 7, 2018 9:18 PM To: dev ; Mailing-List trafficserver Subject: [VOTE] Release Apache Traffic Server 7.1.5 (RC0) I've prepared a release for 7.1.5 (RC0), which i

GitHub Issue #3991 - Truncate byte range responses with RWW.

2018-08-17 Thread Chou, Peter
Hi All, I opened an issue on GitHub #3991 a while back. Somebody just responded that they may be seeing the same thing. Thought I would try the mailing list for some additional exposure :). We were running 6.2.1 with RWW=1, and we found that byte range request responses were truncated. We thou

RE: [VOTE] Release Apache Traffic Server 7.1.4 (RC1)

2018-07-31 Thread Chou, Peter
Compiled on Ubuntu 18.04 LTS. All regression tests passed '-R 1'. -Original Message- From: Chris Lemmons [mailto:alfic...@gmail.com] Sent: Tuesday, July 31, 2018 11:04 AM To: dev@trafficserver.apache.org Subject: Re: [VOTE] Release Apache Traffic Server 7.1.4 (RC1) We're currently runnin

RE: Issue #2416 - Log Collation Memory Leak.

2018-07-30 Thread Chou, Peter
ened a PR #4041 with both memory leaks. Thanks, Peter -Original Message- From: Chou, Peter Sent: Thursday, July 26, 2018 1:42 PM To: dev Subject: RE: Issue #2416 - Log Collation Memory Leak. Leif, 1) No problem. It is a two line change so we can carry in our custom 7.1.x if necessary

RE: Issue #2416 - Log Collation Memory Leak.

2018-07-26 Thread Chou, Peter
8, at 3:14 AM, Chou, Peter wrote: > > Hi All, > > After some additional study on how the ink_atomic_increment() and > LogBuffer::destroy() work together in the LogFile::, LogHost::, and > LogHostList::preproc_and_try_delete() functions, the following is probably a >

RE: Issue #2416 - Log Collation Memory Leak.

2018-07-26 Thread Chou, Peter
pending logs will be outputed to orphan file, and them will not be sent to the failover host. Signed-off-by: Yunkai Zhang -Bryan > On Jul 26, 2018, at 2:14 AM, Chou, Peter wrote: > > Hi All, > > After some additional study on how the ink_atomic_increment() and

RE: Issue #2416 - Log Collation Memory Leak.

2018-07-26 Thread Chou, Peter
led in LogHostList::preproc_and_try_delete() and destroy is called before the end of the function (either within the client SM or in the :done part of the function). Thanks, Peter From: Chou, Peter Sent: Wednesday, July 25, 2018 6:53 PM To: dev@trafficserver.apache.org Subject: Issue #2416 -

Issue #2416 - Log Collation Memory Leak.

2018-07-25 Thread Chou, Peter
Hi All, We are following up on a memory leak that we reported with 6.2.1 and have now verified to be in 7.1.3 also. What happens is that when Log Collation is configured and the log collation host is down that the log buffer will be orphaned and leaked. At first we thought this was a lab only i

Report on compiling master with Ubuntu.

2018-05-22 Thread Chou, Peter
Hi all, I was able to compile the current master branch with a new install of Ubuntu 18.04 Server. It did not work with 14.04 or 16.04 (unless there is some way to update the C++ compiler). I did get a diagnostic message during the compile (happened multiple items, only showing one example).

RE: ATS Memory Leak?

2018-03-27 Thread Chou, Peter
YvwhbK-KWGqA6Fz3kFJE3ZEZMVvzDDo&s=1eayWyMoU-xaIuSroHrzio06A76Gv1apgRS0OjrTlKQ&e= > > Presentations+-+2017?preview=/70255385/74684709/ATSSummit_jemalloc.pptx > > Perhaps we can then see what components of the code is contributing to > the memory buildup. > > Thanks. &

ATS Memory Leak?

2018-03-15 Thread Chou, Peter
Hi All, We have been experiencing a slow memory leak with ATS 6.2.1 which requires a process restart (before memory exhaust) on the order of weeks. We have tried to gather information with a debug build (compiled with --enable-debug and --with-tcmalloc-lib), but the process seems to be unstable

RE: Write Lock

2018-01-25 Thread Chou, Peter
Aaron, Thanks for the response. Jeremy and I were looking for a way to cache an object that would have been blocked by the cache_promote plugin (which uses the API function you show below). We are considering adding an over-ride into this plugin, e.g., special ATS internal header, that could be

Recompile for Meltdown/Spectre?

2018-01-08 Thread Chou, Peter
Hi, We see that there are compiler changes on the way for mitigating the Meltdown/Spectre issues. Is there any recommendation on whether ATS should be re-compiled, or is ATS alright assuming the built-in Lua JIT is only used for local, trusted Lua code? Thanks, Peter

RE: Setting fds_limit.

2017-06-26 Thread Chou, Peter
-24 3:10 GMT+08:00 Chou, Peter : > Hi, > > In adj_system_settings() in proxy/Main.cc, we have (paraphrasing here) -- > > if throttle > (current - head_room) then > cur = max = throttle > setrlimit()... > > Would it make more sense to set -- > >

Setting fds_limit.

2017-06-23 Thread Chou, Peter
Hi, In adj_system_settings() in proxy/Main.cc, we have (paraphrasing here) -- if throttle > (current - head_room) then cur = max = throttle setrlimit()... Would it make more sense to set -- cur = max = throttle + head_room Otherwise, our users see the warning, try to compensate, an

Help with collapsed_connection plugin.

2017-06-21 Thread Chou, Peter
Hi, I am taking a look at the collapsed_connection plugin. There appears to be an assertion failure crash incompatibility between this plugin and changes made in the 6.2.x branch. TS-4387 appears to require all continuations calling TSContSchedule() to have a mutex, but in the plugin no mutex i

ATS with dmalloc on Linux?

2017-02-13 Thread Chou, Peter
Hi, We are looking into some potential memory leaks -- so we are trying to run traffic_server with the dmalloc library (threaded C++ version libdmallocthcxx) linked. I found that the process will abort at start-up inside ink_freelist_new() when running the new executable. I found a hint in TS

Squid log shows TCP_HIT on cache miss expired.

2017-01-26 Thread Chou, Peter
Hi All, We think that we have identified a case where the Squid log will show the transaction result as TCP_HIT even though the cached page was expired. We generate this condition (under ATS 6.1.1) by doing the following -- * Enable negative caching with 120s time-out * Request

Release 6.2.1.

2017-01-19 Thread Chou, Peter
Hi, I thought the R6.2.1 RC0 passed voting a couple of weeks ago. Just want to confirm it is still finalized (nothing new pending) and that we're just waiting on the official release artifacts. Thanks, Peter

Plans for 6.2.1?

2016-10-11 Thread Chou, Peter
Hi, We're wondering if there are plans to release a 6.2.1 version and whether there's a target date for this? I looked on the wiki, but there's nothing certain there for point releases. Thanks, Peter

RE: github rebase merging

2016-09-26 Thread Chou, Peter
Hi, Isn't there a benefit to 'squash and merge' since it can keep some work-in-progress commits from ending up in the main branch history? Just curious if there are other considerations since both squash-and-merge and rebase-and-merge seem pretty similar (both use fast-forward-merging so no mer

Please review fix for TS-4475 Log-Collation core-dump.

2016-06-23 Thread Chou, Peter
Hi all, I am working on a fix for TS-4475 which is a core dump in LogCollationClientSM.cc. I gather that there is not a lot of interest in the Log Collation client so I am reaching out to the mailing list especially for folks familiar with inactivity cop. Background: The core dump occurs when

Question on possible fix for TS-3932.

2015-10-21 Thread Chou, Peter
Hi, I posted a comment with my RCA for TS-3932 (TOS bits not being set on releases > 5.3.0) recently. I have been considering whether this issue can be fixed by moving the call to set dynamic socket options from Connection::open() to Connection::connect(). Note that the underlying issue is tha