JTest features not working

2024-06-18 Thread josiah_vanderzee
Hello, As reported in [ https://github.com/apache/trafficserver/issues/11455, | https://github.com/apache/trafficserver/issues/11455, ] JTest data verification in the cache is broken and has not compiled since the first GitHub commit. This issue prompted the community to consider the JTest fea

Re: Proposed new TS API function: TSHttp2GraceShutdown

2024-06-18 Thread Fei Deng
Ok, after a short discussion with Brian Neradt, we've decided that a few tweaks to the current PR https://github.com/apache/trafficserver/pull/11046 should work. I've added a test to make sure the feature (setting "Connection: close" drains the H2 connection) works as intended. On Tue, Jun 18, 202

Re: Proposed new TS API function: TSHttp2GraceShutdown

2024-06-18 Thread Fei Deng
I didn't find a specific test that tests for connection close in H2, so I wrote a simple one this morning and confirmed that changing the header with hook TS_HTTP_SEND_RESPONSE_HDR_HOOK works. We'll have a discussion this afternoon to discuss it over. On Mon, Jun 17, 2024 at 10:52 PM Fei Deng wro

Re: Proposed new TS API function: TSHttp2GraceShutdown

2024-06-18 Thread Masakazu Kitajo
PR 8178 says: > With this change adding a header-rewrite rule to add the Connection:closed header will still work to trigger the draining logic. But core logic to clean up HTTP/1.x connections will not trigger the draining logic. It doesn't sound like the feature was taken out purposefully. I stil