Re: [E] Re: Proposed change to TS API: TSHeapBuf

2022-08-31 Thread Walt Karas
As a rule of thumb, I prefer using encapsulation/data abstraction. I think perhaps that is one reason I've been a poor match to this project. There doesn't seem to be a consensus that we should follow this rule of thumb. KIt, that would be my preference. But I am part of the consensus I think

Re: [E] Re: Proposed change to CPP API

2022-08-31 Thread Walt Karas
Wow, your question is actually answered in docs: https://docs.trafficserver.apache.org/developer-guide/introduction/header-file-structure.en.html?highlight=cppapi . Run out and buy a lottery ticket, the goddess of good fortune is smiling upon you today. On Wed, Aug 31, 2022 at 7:44 PM Walt Karas

Re: [E] Re: Proposed change to CPP API

2022-08-31 Thread Walt Karas
Headers in tscpp/api must only be used in plugins. Headers in tscpp/util may be used in both core TS and in plugins. Alan created these two directories. This is my memory of what he said about how to use them, you could double check with him. On Wed, Aug 31, 2022 at 4:32 PM Masakazu Kitajo wro

Re: Proposed change to CPP API

2022-08-31 Thread Masakazu Kitajo
Can someone tell me what should be under tscpp/api and tscpp/util ? On Wed, Aug 31, 2022 at 5:07 AM Walt Karas wrote: > I propose moving Cleanup.h from plugins/xdebug to include/ts/api as a part > of https://github.com/apache/trafficserver/pull/9044 . >

Re: Proposed change to TS API: TSHeapBuf

2022-08-31 Thread Shu Kit Chan
Also are we planning to eventually rewrite our existing APIs (where applicable) to use this? On Wed, Aug 31, 2022 at 8:36 AM Masakazu Kitajo wrote: > > What's the advantage of using TSHeapBuf? What issue does it solve? > > > On Wed, Aug 31, 2022 at 7:48 AM Walt Karas > wrote: > > > Described her

Re: Proposed change to TS API: TSHeapBuf

2022-08-31 Thread Masakazu Kitajo
What's the advantage of using TSHeapBuf? What issue does it solve? On Wed, Aug 31, 2022 at 7:48 AM Walt Karas wrote: > Described here: > > https://github.com/apache/trafficserver/blob/os_pkey_cnf_reload/doc/developer-guide/api/functions/TSHeapBuf.en.rst#tsheapbufdata > , > > In PR https://githu