Re: [VOTE] new API for getting the SNI for a client connection

2021-10-05 Thread Sudheer Vinukonda
+1 Sent from my iPhone > On Oct 5, 2021, at 6:29 PM, Brian Neradt wrote: > > +1 > > Thanks Randall. > >> On Tue, Oct 5, 2021 at 12:33 PM Robert O Butts wrote: >> >> +1 >> >> IMO we should have APIs for all SSL/SNI data. >> >>> On Tue, Oct 5, 2021 at 11:25 AM Leif Hedstrom wrote: >>> >>

Re: [VOTE] new API for getting the SNI for a client connection

2021-10-05 Thread Brian Neradt
+1 Thanks Randall. On Tue, Oct 5, 2021 at 12:33 PM Robert O Butts wrote: > +1 > > IMO we should have APIs for all SSL/SNI data. > > On Tue, Oct 5, 2021 at 11:25 AM Leif Hedstrom wrote: > > > +1. > > > > I think the same pattern is in a couple of other “example” plugins as > > well, which could

Re: [VOTE] new API for getting the SNI for a client connection

2021-10-05 Thread Robert O Butts
+1 IMO we should have APIs for all SSL/SNI data. On Tue, Oct 5, 2021 at 11:25 AM Leif Hedstrom wrote: > +1. > > I think the same pattern is in a couple of other “example” plugins as > well, which could be cleaned up the same way. > > — Leif > > > > On Oct 5, 2021, at 11:02 AM, Randall Meyer >

Re: [VOTE] new API for getting the SNI for a client connection

2021-10-05 Thread Leif Hedstrom
+1. I think the same pattern is in a couple of other “example” plugins as well, which could be cleaned up the same way. — Leif > On Oct 5, 2021, at 11:02 AM, Randall Meyer > wrote: > > Hello! > I'd like to propose adding a new API get grab the SNI from the client > connection. > > const

[VOTE] new API for getting the SNI for a client connection

2021-10-05 Thread Randall Meyer
Hello! I'd like to propose adding a new API get grab the SNI from the client connection. const char * TSSslSNIGet(TSVConn sslp, int *length) This would remove some of the redundant code in the rate_limit plugin but also would allow for the rate_limit plugin to be used under BoringSSL. The API

[DISCUSS] Promote or deprecate experimental API TSHttpTxnCntl()

2021-10-05 Thread Leif Hedstrom
Hi all, While poking around, looking for a way to turn off logging for a single transaction (to effectively sample logging activity), I stumbled upon this API in experimental.h: tsapi TSReturnCode TSHttpTxnCntl(TSHttpTxn txnp, TSHttpCntlType cntl, void *data); The intent here was obviously t