Re: [E] Modified and New TS APIs Proposal

2021-07-28 Thread Jeff Elsloo
I pushed a commit to address items one and three, but the issue with item two is that the range of possible values is bound by an enum that maps to `#defines` in core, both of which are zero indexed (0-14). The item at index zero is the 128 byte buffer size, so if someone in the future uses this st

buildbot failure in on trafficserver-website

2021-07-28 Thread buildbot
The Buildbot has detected a new failure on builder trafficserver-website while building trafficserver-website. Full details are available at: https://ci.apache.org/builders/trafficserver-website/builds/24 Buildbot URL: https://ci.apache.org/ Buildslave for this Build: bb_slave7_ubuntu Build

Re: [E] Modified and New TS APIs Proposal

2021-07-28 Thread Alan Carroll
Yes, that seems in the right direction. A few points: 1. If the struct isn't opaque, then it should be passed by pointer, not by value. 2. There fields must be optional, e.g. I shouldn't be forced to pick some value for the buffering. I'm not sure of the best way to do this - a bit mask? An "inval