Re: Design Review Request: Log Throttling

2020-10-17 Thread Leif Hedstrom
Huh I guess I should read the patch, it already does this ... then I agree with Sudheer and we should replace all of this with the new one, perhaps with configuration for each log level on frequency. I don’t like the idea of having two Warning flavors, when would I use one over the other ? I li

Re: Design Review Request: Log Throttling

2020-10-17 Thread Leif Hedstrom
> On Oct 16, 2020, at 18:00, Sudheer Vinukonda > wrote: > > +1 > > This sort of throttling ability is very important and useful to have. > > A minor suggestion on the implementation proposal - it feels like it’d far > simpler to localize the change to the definition of Warning, Error et

Re: Design Review Request: Log Throttling

2020-10-17 Thread Brian Neradt
Thanks for the feedback. I agree that if we were to replace all of them, we'd might as well replace the implementations of Warning, Error, etc. with this throttled version. My initial intent was not to replace all of the messages, but to replace a handful of Errors, Warnings, etc. with the throttl