[GitHub] [trafficserver-ingress-controller] shukitchan commented on pull request #6: Integrate fluentd, prometheus and grafana

2020-06-16 Thread GitBox
shukitchan commented on pull request #6: URL: https://github.com/apache/trafficserver-ingress-controller/pull/6#issuecomment-645071984 1. I don't think we should include the exporter this way. Rather we should perhaps use "submodule" ? 2. Can the prometheus/grafana live in its own name

[GitHub] [trafficserver-ingress-controller] shukitchan commented on a change in pull request #6: Integrate fluentd, prometheus and grafana

2020-06-16 Thread GitBox
shukitchan commented on a change in pull request #6: URL: https://github.com/apache/trafficserver-ingress-controller/pull/6#discussion_r441206067 ## File path: Dockerfile ## @@ -36,6 +36,7 @@ RUN curl -L https://www-us.apache.org/dist/trafficserver/trafficserver-8.0.7.tar CO

[GitHub] [trafficserver-ingress-controller] rishabhc opened a new pull request #6: Integrate fluentd, prometheus and grafana

2020-06-16 Thread GitBox
rishabhc opened a new pull request #6: URL: https://github.com/apache/trafficserver-ingress-controller/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u