null_transform.c

2020-03-06 Thread Walt Karas
Some questions about null_transform.c (the mother of all transform plugins). Is this, https://github.com/apache/trafficserver/blob/d9f647ca7c15d0eb4687fa59706ab246f49ece1b/example/plugins/c-api/null_transform/null_transform.c#L192 , really a reliable way to make sure all transform-related resource

Re: [API Proposal] Global Arg slots

2020-03-06 Thread Alan Carroll
I am in favor of this because although the replace of In Name Only types with void * makes a more risky API, it is (in my judgement) a relatively minor risk especially since almost all of those types are in fact Continuations and the internals can check the dynamic_cast for success. I think it is m

Re: [ANNOUNCE] Apache Traffic Server Spring 2020 Summit

2020-03-06 Thread Bryan Call
Regarding the status of the summit, there are a couple companies from committers that have international travel bans at the moment. We are determining if we should cancel the summit or not and a final decision will be made by 4/1. I don’t recommend booking any travel arrangements that can’t e

Re: [ANNOUNCE] Apache Traffic Server Spring 2020 Summit

2020-03-06 Thread Bryan Call
Regarding the status of the summit, there are a couple companies from committers that have international travel bans at the moment. We are determining if we should cancel the summit or not and a final decision will be made by 4/1. I don’t recommend booking any travel arrangements that can’t e

Re: proxy.config.body_factory.response_suppression_mode config change

2020-03-06 Thread Bryan Call
+1 - Looks good to me. -Bryan > On Mar 6, 2020, at 9:49 AM, Sudheer Vinukonda > wrote: > > We've a lot of use cases, that trigger internal requests via TSFetchUrl. > We've body_factory enabled (0) for our response error templates which is > nice, but we'd like to suppress the error template

proxy.config.body_factory.response_suppression_mode config change

2020-03-06 Thread Sudheer Vinukonda
We've a lot of use cases, that trigger internal requests via TSFetchUrl. We've body_factory enabled (0) for our response error templates which is nice, but we'd like to suppress the error template responses for internal requests (note that body factory code is quite a bit of an overhead due to m

Re: TSFetchUrl support for dechunking in HTTP/1.1 - new API TSFetchFlagSet

2020-03-06 Thread Sudheer Vinukonda
Sorry, I just realized that TSFetchUrl() can be called directly without calling TSFetchCreate(). So, to preserve backward compatibility and to be able to set the fetch flags, I'm going to add a new `TSFetchFlagSet` API as below.  The API accepts a previously created FetchSM context and the flags

Re: TSFetchUrl support for dechunking in HTTP/1.1

2020-03-06 Thread Sudheer Vinukonda
I'm going to call this in and make the change to the TSFetchUrl() API to remove setting `TS_FETCH_FLAGS_DECHUNK` flag by default. After discussing with Leif over slack, it's worth explicitly clarifying that plugins that do want to still have `TS_FETCH_FLAGS_DECHUNK` set can do so by simply pass