Re: "[API] TSHttpSsnStartTime"

2019-09-19 Thread Sudheer Vinukonda
Ugh, I was typing half asleep and while in a meeting (thought you could still read my mind though :) ) Anyway, will this work? milestones[SSN_START] = ua_txn->get_proxy_ssn()->ssn_start_time; On Thursday, September 19, 2019, 03:31:14 PM PDT, Alan Carroll wrote: No, that won't work -

Re: "[API] TSHttpSsnStartTime"

2019-09-19 Thread Alan Carroll
No, that won't work - the start time is for the session, not the transaction. On Thu, Sep 19, 2019 at 4:37 PM Sudheer Vinukonda wrote: > Of course, by automatic, I don't mean out of thin air :) - you just need > to initialize it in the TXN milestones just like you'd do the rest of the > TXN mil

Re: "[API] TSHttpSsnStartTime"

2019-09-19 Thread Sudheer Vinukonda
Of course, by automatic, I don't mean out of thin air :) - you just need to initialize it in the TXN milestones just like you'd do the rest of the TXN milestones. for e.g in HttpSM::init().   milestones[SSN_START] = Thread::get_hrtime(); The API doesn't need to do anything different, you just ne

Re: "[API] TSHttpSsnStartTime"

2019-09-19 Thread Alan Carroll
Currently, the start time is stored in ProxySession. How would adding `SSN_START` to the milestones work automatically? The value would still be stored in ProxySession and not in the milestones array. Would it be copied out at the start of every transaction to the HttpSM local milestone array? If n

Re: "[API] TSHttpSsnStartTime"

2019-09-19 Thread Sudheer Vinukonda
Hmm..TXN has access to the session it's associated with and I personally don't feel it'd look ugly or bad to combine session related data to a TXN milestone API (we already do that in Access logs).  The existing API (`sm->milestones[milestone]` ) should just work automatically, if `SSN_START_TI

Re: "[API] TSHttpSsnStartTime"

2019-09-19 Thread Alan Carroll
It's not really associated with the Transaction, it's a session property. It would be somewhat ugly to implement that way, as you would then need to do special checks on the milestone enum to handle the session start time differently, since it's in a completely different place. The code for this fu

Re: "[API] TSHttpSsnStartTime"

2019-09-19 Thread Sudheer Vinukonda
Hmm...Would it make sense to add this as a milestone and extend the existing API `TSHttpTxnMileStoneGet` (and `TSMilestonesType`) to support session start time and possibly other session level context associated to that Txn? Thoughts? On Thursday, September 19, 2019, 11:38:47 AM PDT, Alan

"[API] TSHttpSsnStartTime"

2019-09-19 Thread Alan Carroll
I'm playing with some session stuff and I'd like to add this, since the data is already stored in the session, it's trivial to access.