Re: PR 5803 - 0 vs nullptr

2019-08-08 Thread Walt Karas
And thanks for outing Alan for talking behind my back (literally). On Thu, Aug 8, 2019 at 4:34 PM Leif Hedstrom wrote: > > > > On Aug 8, 2019, at 2:12 PM, Alan Carroll < > solidwallofc...@verizonmedia.com> wrote: > > > > Looking at this PR, it would be better if it could use "nullptr" instead >

Re: PR 5803 - 0 vs nullptr

2019-08-08 Thread Leif Hedstrom
> On Aug 8, 2019, at 2:12 PM, Alan Carroll > wrote: > > Looking at this PR, it would be better if it could use "nullptr" instead of > "0", but that depends on the requirement that plugins be built with a C++ > compiler. I know that's been discussed on and off and if I recall correctly > we di

PR 5803 - 0 vs nullptr

2019-08-08 Thread Alan Carroll
Looking at this PR, it would be better if it could use "nullptr" instead of "0", but that depends on the requirement that plugins be built with a C++ compiler. I know that's been discussed on and off and if I recall correctly we did commit to that. Is my memory correct? Can we require a C++ compile

Proposed TS API change: Make TS_NULL_MLOC a valid C compile-time constant.

2019-08-08 Thread Walt Karas
https://github.com/apache/trafficserver/pull/5803