Re: ATS - Quic - Connection Migration

2019-01-07 Thread 宋辰伟
Hi traffic_quic only select a new connection id which dispatch from traffic_server when enable_cm = true, IIUC. But it should be fine if the client has changed the addr(Please let me know if it doesn’t work). scw00 > 在 2019年1月8日,下午3:28,p...@campus.technion.ac.il 写道: > > Hi, > I am a student

Re: autest failures

2019-01-07 Thread Leif Hedstrom
> On Jan 7, 2019, at 5:28 PM, Pushkar Pradhan wrote: > > Yes I saw that condition later. I think it could be done for http1.1 but is > it a good idea to skip tests? I’ve had this discussion before, and my personal preference would be that we never do these types of checks, but rather, have t

Re: autest failures

2019-01-07 Thread Pushkar Pradhan
Yes I saw that condition later. I think it could be done for http1.1 but is it a good idea to skip tests? On Mon, Jan 7, 2019 at 4:14 PM Walt Karas wrote: > Many have this to skip if no http2 support but I don't know if it can > be use to test support for http1.1 : > > # need Curl > Test.SkipUnl

Re: autest failures

2019-01-07 Thread Walt Karas
Many have this to skip if no http2 support but I don't know if it can be use to test support for http1.1 : # need Curl Test.SkipUnless( Condition.HasProgram("curl", "Curl need to be installed on system for this test to work"), Condition.HasCurlFeature('http2') ) On Mon, Jan 7, 2019 at 4:5

RE: autest failures

2019-01-07 Thread Pushkar Pradhan
I tried running the autests on the master branch and saw many many failures. Most of them failed because my RHEL box doesn't have a recent curl that supports http1.1 option. The fix was obvious but I got no warning about this, I had to figure this out. Would it be reasonable to include and build t

Re: API change in 8.x

2019-01-07 Thread Aaron Canary
In similar situations, we have made a compatibility layer which can be dropped when support for 7 is dropped. Something like... PluginAts7Compatibility.h #ifdef TS_VERSION_MAJOR <= 7 int TSHttpTxnStatusSet(...) { return TSHttpTxnSetHttpRetStatus(...); } #endif Then your plugin can use TSHttpTx

[REMINDER] Go through your open Issues (ASAP)

2019-01-07 Thread Leif Hedstrom
Hi all, please take a few minutes and go through your open Issues, and close those which are no longer relevant or already fixed. We will need to do a full triage of all open Issues, and if you all can help out cleaning things out, it’ll make that process easier. Thanks, — Leif P.s In the G