Re: Dealing with reverts on master

2018-08-22 Thread Derek Dagit
+1 My cheat sheet for these rules is growing lengthy. Would it be a good idea to publish to the wiki? On Wed, Aug 22, 2018 at 1:23 PM, Bryan Call wrote: > +1 - sounds good > > -Bryan > > > > > On Aug 9, 2018, at 4:15 PM, Leif Hedstrom wrote: > > > > We have a few commits that have been reverte

Re: [DISCUSS] Following redirects to 'localhost'

2018-08-22 Thread Derek Dagit
Bryan, some clarification questions: > 2. 403 What should we do on the N+1st redirect? Do we try to resolve the target host and 403 that too, or just return it to the client regardless of how it resolves? This is why I went with "Return" by default rather than "Reject". > 3. I like Lief’s pr

Re: logging

2018-08-22 Thread Dk Jack
Hi Bryan, Nishant helped me out with the config. I have it working now. Thanks. > On Aug 22, 2018, at 11:22 AM, Bryan Call wrote: > > What does your logging configuration file look like (logging.config)? > > -Bryan > > > >> On Aug 8, 2018, at 12:01 PM, Dk Jack wrote: >> >> Hi, >> In my

Re: Dealing with reverts on master

2018-08-22 Thread Bryan Call
+1 - sounds good -Bryan > On Aug 9, 2018, at 4:15 PM, Leif Hedstrom wrote: > > We have a few commits that have been reverted on Master, which requires a > second “revert” commit (because of the review requirements). This can cause > confusion, particularly on the ChangeLog / Release Notes,

Re: logging

2018-08-22 Thread Bryan Call
What does your logging configuration file look like (logging.config)? -Bryan > On Aug 8, 2018, at 12:01 PM, Dk Jack wrote: > > Hi, > In my records.config, I configured my logging as: > > CONFIG proxy.config.log.logging_enabled INT 3 > > However, I don't see the access log file being written

Re: [DISCUSS] Following redirects to 'localhost'

2018-08-22 Thread Bryan Call
1. Yes 2. 403 3. I like Lief’s proposal. You might want to add another option to add non-routable IPs to the list too. I would create a configuration option called proxy.config.http.redirect_enabled and start with 0 as off and set proxy.config.http.number_of_redirections to 1 as the default. W

Re: connection attempts timeout difference b/w GET and POST requests in trafficserver

2018-08-22 Thread Nishant Gaurav
Disregard this mail, Susan had already answered this one. Thank you Nishant On Tue, Aug 21, 2018 at 5:18 PM Nishant Gaurav wrote: > Hi, > > I see that there is a large difference b/w the default value of timeout > for GET and POST (and PUT) requests (in seconds). > > CONFIG proxy.config.http.co

Re: connection attempts timeout difference b/w GET and POST requests in trafficserver

2018-08-22 Thread David Carlin
There is a bug for these settings where the timeout was actually TTFB and not a timeout for completion of three-way handshake: https://issues.apache.org/jira/browse/TS-242 https://github.com/apache/trafficserver/pull/4028 One reason to set POST timeouts much longer than GET timeouts is due to the

connection attempts timeout difference b/w GET and POST requests in trafficserver

2018-08-22 Thread Nishant Gaurav
Hi, I see that there is a large difference b/w the default value of timeout for GET and POST (and PUT) requests (in seconds). CONFIG proxy.config.http.connect_attempts_timeout INT 30 CONFIG proxy.config.http.post_connect_attempts_timeout INT 1800 I couldn’t think of a reason why it should be tha