Re: logging

2018-08-08 Thread Nishant Gaurav
Just check if you have a LogObject defined in log_xml.config (wiki : https://docs.trafficserver.apache.org/en/6.2.x/admin-guide/monitoring/logging/log-formats.en.html#defining-log-objects) Nishant On 8/8/18, 12:02 PM, "Dk Jack" wrote: 6.2.1. Thanks for you help.

logging

2018-08-08 Thread Dk Jack
Hi, In my records.config, I configured my logging as: CONFIG proxy.config.log.logging_enabled INT 3 However, I don't see the access log file being written when I send request. Is there some additional config that I need to do? I am using ATS version 6.2.1. Thanks for you help. Regards, Dk.

Re: [PROPOSAL] Strct 1 commit per PR rule (multiple PRs is fine)

2018-08-08 Thread Alan Carroll
I have to say, having experienced these other pains, I am less unhappy about merge commits than I used to be. On Wed, Aug 8, 2018 at 11:49 AM Derek Dagit wrote: > Just FYI, IF we went with merge comments then I believe github by default > lets us give the message in the new commit that it create

Re: [PROPOSAL] Strct 1 commit per PR rule (multiple PRs is fine)

2018-08-08 Thread Derek Dagit
Just FYI, IF we went with merge comments then I believe github by default lets us give the message in the new commit that it creates—It is the PR title by default I think. With rebase-merge github won't change the commit message I think, but we could require an Issue # to be in commit comments befo

Re: [PROPOSAL] Strct 1 commit per PR rule (multiple PRs is fine)

2018-08-08 Thread Alan Carroll
Another approach might be to use issues more, to substitute for JIRA tickets. E.g. every PR has an issue and the commits are labeled with that issue #. That would give us a key string to search for in the commit messages and handle the case (which merge commits don't) where a later commit is requir