Re: [DISCUSS] Following redirects to 'localhost'

2018-08-06 Thread Derek Dagit
1. Yep 2. I see multiple possible answers as well... 3. ... and the 0,1,2-style config having either default sounds OK. Regarding 1)2), Could we resolve and then check if the address is a loopback address? 3) Hmm, not sure about the use of *cast addresses either. 4) The VIP deployment I

Re: [DISCUSS] Following redirects to 'localhost'

2018-08-06 Thread Leif Hedstrom
> On Aug 6, 2018, at 4:50 PM, Alan Carroll > wrote: > > 1. Yes. Agreed. > > 2. I think a 403 I can go either way. The HTTP way would be to just return the Location as is (i.e. retain the redirect), following redirects is a little unorthodox. Maybe since we are adding new configuration(s

Re: [DISCUSS] Following redirects to 'localhost'

2018-08-06 Thread Alan Carroll
1. Yes. 2. I think a 403 3. We can add more sophisticated configuration later, if there turns out to be a need. On Mon, Aug 6, 2018 at 4:48 PM Derek Dagit wrote: > ATS can be configured such that when it receives a redirect (3xx) response > from an origin server, it will follow the redirect i

Re: [PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-06 Thread Derek Dagit
+1 for the rename +1 for adding the two new functions On Mon, Aug 6, 2018 at 4:41 PM, Alan Carroll < solidwallofc...@oath.com.invalid> wrote: > +1 > > On Mon, Aug 6, 2018 at 4:18 PM Leif Hedstrom wrote: > > > > > > > > On Aug 6, 2018, at 3:14 PM, Leif Hedstrom wrote: > > > > > > We have this AP

[DISCUSS] Following redirects to 'localhost'

2018-08-06 Thread Derek Dagit
ATS can be configured such that when it receives a redirect (3xx) response from an origin server, it will follow the redirect itself rather than return the response to the client. Consider the scenario when the redirect response contains a Location header field with a destination of localhost. In

Re: [PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-06 Thread Alan Carroll
+1 On Mon, Aug 6, 2018 at 4:18 PM Leif Hedstrom wrote: > > > > On Aug 6, 2018, at 3:14 PM, Leif Hedstrom wrote: > > > > We have this API: > > > > void TSHttpTxnSetHttpRetStatus(TSHttpTxn txnp, TSHttpStatus > http_retstatus); > > > > > > Which on its own is a little strange, but looking at

Re: [PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-06 Thread Leif Hedstrom
> On Aug 6, 2018, at 3:14 PM, Leif Hedstrom wrote: > > We have this API: > > void TSHttpTxnSetHttpRetStatus(TSHttpTxn txnp, TSHttpStatus > http_retstatus); > > > Which on its own is a little strange, but looking at code, and talking to > Alan, I believe this was added when we added

[PROPOSAL] Rename TSHttpTxnSetHttpRetStatus()

2018-08-06 Thread Leif Hedstrom
We have this API: void TSHttpTxnSetHttpRetStatus(TSHttpTxn txnp, TSHttpStatus http_retstatus); Which on its own is a little strange, but looking at code, and talking to Alan, I believe this was added when we added remap plugins long ago, to allow such plugins to modify status codes wi