Re: [API Proposal] - TSVConnArgs

2017-11-15 Thread Alan Carroll
1) Generally the hook names aren't conjugated, more like 'TS_VCONN_CONNECT_HOOK' and 'TS_VCONN_ACCEPT_HOOK'. 2) 'TS_VCONN_CLOSE_HOOK' is required. That's one the the issues that sparked all of this, the inability to have a hook where VConn related data can be cleaned up. On Wed, Nov 15, 2017 at 9:

Re: [API Proposal] - TSVConnArgs

2017-11-15 Thread Chao Xu
Yes, Origin Server. :-) TS_VCONN_CONNECTED_HOOK maybe more accurate than TS_VCONN_OPENED_HOOK for "once a connection is established" - Oknet 2017-11-15 23:08 GMT+08:00 Alan Carroll : > Ah, by "OS" you mean "Origin Server", not "Operating System". > > On Wed, Nov 15, 2017 at 9:06 AM, Chao Xu wr

Re: [API Proposal] - TSVConnArgs

2017-11-15 Thread Alan Carroll
Ah, by "OS" you mean "Origin Server", not "Operating System". On Wed, Nov 15, 2017 at 9:06 AM, Chao Xu wrote: > TS_VCONN_OPENED_HOOK for OS side and TS_VCONN_ACCEPTED_HOOK for client > side. > > - Oknet > > 2017-11-15 23:04 GMT+08:00 Alan Carroll invalid>: > > > How are those different? In term

Re: [API Proposal] - TSVConnArgs

2017-11-15 Thread Chao Xu
TS_VCONN_OPENED_HOOK for OS side and TS_VCONN_ACCEPTED_HOOK for client side. - Oknet 2017-11-15 23:04 GMT+08:00 Alan Carroll : > How are those different? In terms of names, if you want consistency then > TS_NET_ACCEPT_HOOK might be the best choice, aligning with > TS_EVENT_NET_ACCEPT which is th

Re: [API Proposal] - TSVConnArgs

2017-11-15 Thread Chao Xu
IMO, It is time to pull the ssl hooks from TSHttpHookID enum. ``` typedef enum { TS_VCONN_FIRST_HOOK, TS_VCONN_ACCEPTED_HOOK = TS_VCONN_FIRST_HOOK, TS_VCONN_SSL_SNI_HOOK, TS_VCONN_SSL_CERT_HOOK = TS_VCONN_SSL_SNI_HOOK, TS_VCONN_SSL_SERVERNAME_HOOK, TS_VCONN_OPENED_HOOK, TS_VCONN_SSL_

Re: [API Proposal] - TSVConnArgs

2017-11-15 Thread Alan Carroll
How are those different? In terms of names, if you want consistency then TS_NET_ACCEPT_HOOK might be the best choice, aligning with TS_EVENT_NET_ACCEPT which is the event that signals that action. On Wed, Nov 15, 2017 at 8:58 AM, Chao Xu wrote: > Hi AMC, > > " We should rename TS_VCONN_PRE_ACCEP

Re: [API Proposal] - TSVConnArgs

2017-11-15 Thread Chao Xu
Hi AMC, " We should rename TS_VCONN_PRE_ACCEPT_HOOK to TS_VCONN_START_HOOK. " IMO, TS_VCONN_OPENED_HOOK when the OS connection is established. TS_VCONN_ACCEPTED_HOOK as a instead for TS_VCONN_PRE_ACCEPT_HOOK. - Oknet 2017-11-14 23:48 GMT+08:00 Dk Jack : > I concur with the idea that connection