Re: TS-4703 && PR-829

2016-07-28 Thread James Peach
> On Jul 29, 2016, at 12:29 AM, Susan Hinrichs > wrote: > > > > On 7/28/2016 5:05 AM, James Peach wrote: >>> On Jul 28, 2016, at 7:33 PM, James Peach wrote: >>> >>> On Jul 28, 2016, at 5:50 AM, Petar Bozhidarov Penkov wrote: Hello, I am writing in accordan

Re: TS-4703 && PR-829

2016-07-28 Thread Susan Hinrichs
On 7/28/2016 5:05 AM, James Peach wrote: On Jul 28, 2016, at 7:33 PM, James Peach wrote: On Jul 28, 2016, at 5:50 AM, Petar Bozhidarov Penkov wrote: Hello, I am writing in accordance with the referenced Pull Request and JIRA issue. I am proposing a GET-er method for Transactions's under

Re: TS-4703 && PR-829

2016-07-28 Thread James Peach
> On Jul 28, 2016, at 7:33 PM, James Peach wrote: > > >> On Jul 28, 2016, at 5:50 AM, Petar Bozhidarov Penkov >> wrote: >> >> Hello, >> >> I am writing in accordance with the referenced Pull Request and JIRA issue. >> I am proposing a GET-er method for Transactions's underlying protocol. Th

Re: Dynamic config

2016-07-28 Thread James Peach
> On Jul 23, 2016, at 4:08 AM, Penkar, Cylus wrote: > > Thanks James! This exactly what I was looking for! I am going to play with it. > > Making an assumption that the config will be persisted into records.config > right? I expect so, since there is no distinction between records added by pl

Re: Is it correct to include a header file that is named with prefix P_ in proxy directory ?

2016-07-28 Thread James Peach
> On Jul 26, 2016, at 7:18 PM, Chao Xu wrote: > > Hi All, > > https://cwiki.apache.org/confluence/display/TS/Coding+Style#CodingStyle-MemberVariables > Header files > > In most subsystems, header files are named with a P_ or I_ prefix. P_ files > should contain any types and definitions that a

Re: TSHttpTxnIsWebsocket API function

2016-07-28 Thread James Peach
> On Jul 24, 2016, at 11:08 PM, Oliver Goodman wrote: > > JIRA issue TS-4698 and pull request > https://github.com/apache/trafficserver/pull/822 propose to add a TS API > function to determine whether the current client request represents a > websocket connection attempt. > > The motivation:

Re: TS-4703 && PR-829

2016-07-28 Thread James Peach
> On Jul 28, 2016, at 5:50 AM, Petar Bozhidarov Penkov > wrote: > > Hello, > > I am writing in accordance with the referenced Pull Request and JIRA issue. > I am proposing a GET-er method for Transactions's underlying protocol. This > relates to TS-2987 and is effectively one of the proposed s