Re: TS-4523: Add the ability to pause/resume data consumption in the CPP API

2016-06-21 Thread David Ben Zakai
Hi guys, Thanks for your feedback James, I can expose another method - lets say *void resume(uint ms) *that will schedule it for the user, sounds good? Brian, I want to buffer to a certain limit and when the 'Content-Length' header is missing we can't know the file size, so we'll start buffering

[GitHub] trafficserver pull request #692: [TS-4500] add cookie-rewrite functionality ...

2016-06-21 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/692 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

Re: TS-4523: Add the ability to pause/resume data consumption in the CPP API

2016-06-21 Thread Brian Geffon
The thing I'm missing about this, why can't you just keep buffering to the same file while you're doing analysis? I don't see why you need to pause anything? Brian On Friday, June 17, 2016, David Ben Zakai wrote: > Hi all, > > I'd like to suggest an API change in the CPP API Transformation inte

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/692 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/212/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/692 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/318/ for details. --- If your project is set up for it, you can reply to this email and have your r

Re: TS-4523: Add the ability to pause/resume data consumption in the CPP API

2016-06-21 Thread James Peach
> On Jun 16, 2016, at 11:43 AM, David Ben Zakai > wrote: > > Hi all, > > I'd like to suggest an API change in the CPP API Transformation interface. > > My own use case is that I'd like to be able to pause the transformation, > handle what I can from the file and release the buffered content b

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-21 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/692 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver issue #731: TS-4569: New Coverity issues found in updated scan

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/731 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/317/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #731: TS-4569: New Coverity issues found in updated scan

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/731 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/211/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request #731: TS-4569: New Coverity issues found in updat...

2016-06-21 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/731 TS-4569: New Coverity issues found in updated scan Fixed issues: 1356977 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/traff

[GitHub] trafficserver issue #730: TS-4569: New Coverity issues found in updated scan

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/730 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/210/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #730: TS-4569: New Coverity issues found in updated scan

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/730 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/316/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #727: TS-4571: Fix "pointer to local outside scope" (CID...

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/727 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/209/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/728 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/208/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #727: TS-4571: Fix "pointer to local outside scope" (CID...

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/727 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/315/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/728 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/314/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver pull request #730: TS-4569: New Coverity issues found in updat...

2016-06-21 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/730 TS-4569: New Coverity issues found in updated scan Fixed issues: 1356980 and 1356979 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bry

[GitHub] trafficserver issue #727: TS-4571: Fix "pointer to local outside scope" (CID...

2016-06-21 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/727 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...

2016-06-21 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/728 trying again ... [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled a

[GitHub] trafficserver pull request #729: TS-4569: New Coverity issues found in updat...

2016-06-21 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/729 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request #726: TS-4569: New Coverity issues found in updat...

2016-06-21 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/726 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver issue #729: TS-4569: New Coverity issues found in updated scan

2016-06-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/729 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #726: TS-4569: New Coverity issues found in updated scan

2016-06-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/726 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #727: TS-4571: Fix "pointer to local outside scope" (CID...

2016-06-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/727 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver issue #728: TS-4572: Fix "Unchecked return value" (CID 1356972...

2016-06-21 Thread bryancall
Github user bryancall commented on the issue: https://github.com/apache/trafficserver/pull/728 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #729: TS-4569: New Coverity issues found in updat...

2016-06-21 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/729 TS-4569: New Coverity issues found in updated scan Fixed issues: 1356981 and 1356983 You can merge this pull request into a Git repository by running: $ git pull https://github.com/bry

[GitHub] trafficserver pull request #728: TS-4572: Fix "Unchecked return value" (CID ...

2016-06-21 Thread PSUdaemon
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/728 TS-4572: Fix "Unchecked return value" (CID 1356972) If the function returns an error value, the error value may be mistaken for a normal value. In get_effective_host: Value returned fro

Re: [PROPOSAL] One more clang-format change for 7.0.0

2016-06-21 Thread Phil Sorber
On Tue, Jun 21, 2016 at 2:31 PM James Peach wrote: > > > On Jun 21, 2016, at 12:19 PM, Phil Sorber wrote: > > > > So I was +1 on this, but now looking at the full diff I am -0. I wanted > to > > get others take on this. It aligns *all* assignments not just declaration > > ones. > > > > For examp

[GitHub] trafficserver issue #726: TS-4569: New Coverity issues found in updated scan

2016-06-21 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/726 trying a manual trigger [approve ci]. Bloody jenkins... Or github. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #726: TS-4569: New Coverity issues found in updated scan

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/726 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/312/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #727: TS-4571: Fix "pointer to local outside scope" (CID...

2016-06-21 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/727 trying a manual trigger [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] trafficserver issue #727: TS-4571: Fix "pointer to local outside scope" (CID...

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/727 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/311/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver pull request #726: TS-4569: New Coverity issues found in updat...

2016-06-21 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/726 TS-4569: New Coverity issues found in updated scan Fixes for issues: 1356985, 1356984, and 1356982 You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] trafficserver pull request #727: TS-4571: Fix "pointer to local outside scop...

2016-06-21 Thread PSUdaemon
GitHub user PSUdaemon opened a pull request: https://github.com/apache/trafficserver/pull/727 TS-4571: Fix "pointer to local outside scope" (CID 1356978) Dereferencing the returned or out-of-scope stack pointer will access an invalid location on the stack after its scope or after th

Re: [PROPOSAL] One more clang-format change for 7.0.0

2016-06-21 Thread James Peach
> On Jun 21, 2016, at 12:19 PM, Phil Sorber wrote: > > So I was +1 on this, but now looking at the full diff I am -0. I wanted to > get others take on this. It aligns *all* assignments not just declaration > ones. > > For example: > - c->vio.op = VIO::READ; > + c->vio.op= VIO::READ; > c

Re: [PROPOSAL] One more clang-format change for 7.0.0

2016-06-21 Thread Phil Sorber
So I was +1 on this, but now looking at the full diff I am -0. I wanted to get others take on this. It aligns *all* assignments not just declaration ones. For example: - c->vio.op = VIO::READ; + c->vio.op= VIO::READ; c->base_stat = cache_lookup_active_stat; CACHE_INCREMENT_DYN_STAT(c->

[GitHub] trafficserver pull request #725: TS-4568: Milestones where changed from seco...

2016-06-21 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver issue #725: TS-4568: Milestones where changed from seconds to ...

2016-06-21 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/725 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #725: TS-4568: Milestones where changed from seco...

2016-06-21 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/725 TS-4568: Milestones where changed from seconds to milliseconds You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver

[GitHub] trafficserver pull request #724: TS-4470: ASAN stack-buffer-overflow when sl...

2016-06-21 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/724 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

Re: [DISCUSS] Relax minimum OS version requirements ?

2016-06-21 Thread Bryan Call
+1 - I would be great to have C++11 support. I would like to see range for added to the list of acceptable C++11 features to use. -Bryan > On Jun 16, 2016, at 10:53 AM, Leif Hedstrom wrote: > > Hi, > > [Tldr; We bump the minimum supported version to CentOS7/RHEL7, or, > CentOS6/RHEL6 + de

[GitHub] trafficserver issue #724: TS-4470: ASAN stack-buffer-overflow when slow log ...

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/724 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/310/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #724: TS-4470: ASAN stack-buffer-overflow when slow log ...

2016-06-21 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/724 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/203/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request #724: TS-4470: ASAN stack-buffer-overflow when sl...

2016-06-21 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/724 TS-4470: ASAN stack-buffer-overflow when slow log is enabled Update to use offset too You can merge this pull request into a Git repository by running: $ git pull https://github.com/br

[GitHub] trafficserver pull request #718: TS-4543: Fix core in HttpSM::tunnel_handler...

2016-06-21 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/718#discussion_r67817437 --- Diff: proxy/http/HttpSM.cc --- @@ -2722,7 +2722,10 @@ HttpSM::tunnel_handler_post(int event, void *data) { STATE_ENTER(&HttpSM::tunnel_han

[GitHub] trafficserver pull request #718: TS-4543: Fix core in HttpSM::tunnel_handler...

2016-06-21 Thread oknet
Github user oknet commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/718#discussion_r67816840 --- Diff: proxy/http/HttpSM.cc --- @@ -2841,9 +2844,9 @@ HttpSM::tunnel_handler_push(int event, void *data) ink_assert(data == &tunnel);