[GitHub] trafficserver issue #697: TS-4510: support multiple header with same name

2016-06-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/697 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/288/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #697: TS-4510: support multiple header with same name

2016-06-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/697 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/180/ for details. --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] trafficserver issue #697: TS-4510: support multiple header with same name

2016-06-15 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/697 @jpeach , I just updated according to your comments. pls take a look. once i get a thumbs up, will definitely squash the commits before merge --- If your project is set up for it, you c

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-15 Thread zizhong
Github user zizhong commented on the issue: https://github.com/apache/trafficserver/pull/692 Thanks for the instructive comments. I've fixed most of them. For the namespace, I would keep it as it makes code clearer. About supporting **Set-Cookie**, let me address it with another ti

[GitHub] trafficserver issue #644: [TS 4437] Add new limit rate example plugin

2016-06-15 Thread yatsukhnenko
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/644 OK, I will do, but could you first look at the first two commits separately? There are various operation logic and I have some concerns about it. At first one I calculate time which

[GitHub] trafficserver issue #697: TS-4510: support multiple header with same name

2016-06-15 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/697 This looks OK to me, though it is a little opaque in the way that Lua stack code tends to be. I would like to see some reduction in copy/paste in another commit on this PR, but if you want to d

[GitHub] trafficserver pull request #697: TS-4510: support multiple header with same ...

2016-06-15 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/697#discussion_r67285947 --- Diff: plugins/experimental/ts_lua/ts_lua_server_request.c --- @@ -258,10 +286,27 @@ ts_lua_server_request_get_headers(lua_State *L) while (fie

[GitHub] trafficserver pull request #697: TS-4510: support multiple header with same ...

2016-06-15 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/697#discussion_r67285081 --- Diff: plugins/experimental/ts_lua/ts_lua_server_response.c --- @@ -102,11 +104,27 @@ ts_lua_server_response_get_headers(lua_State *L) while (f

[GitHub] trafficserver pull request #697: TS-4510: support multiple header with same ...

2016-06-15 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/697#discussion_r67285016 --- Diff: plugins/experimental/ts_lua/ts_lua_server_response.c --- @@ -152,10 +172,21 @@ ts_lua_server_response_header_get(lua_State *L) if (key &

[GitHub] trafficserver pull request #697: TS-4510: support multiple header with same ...

2016-06-15 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/697#discussion_r67284564 --- Diff: plugins/experimental/ts_lua/ts_lua_server_response.c --- @@ -198,13 +230,25 @@ ts_lua_server_response_header_set(lua_State *L) field_loc

[GitHub] trafficserver issue #666: TS-4377: update documentation links in default con...

2016-06-15 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/666 @jsime Ready to merge this one? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] trafficserver pull request #704: TS-4531: Clarify time unit confusion in Hos...

2016-06-15 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/704 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #718: TS-4543: Fix core in HttpSM::tunnel_handler...

2016-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/718 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #700: TS-4488: fix Segmentation fault at HttpSM::...

2016-06-15 Thread yatsukhnenko
Github user yatsukhnenko closed the pull request at: https://github.com/apache/trafficserver/pull/700 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] trafficserver issue #700: TS-4488: fix Segmentation fault at HttpSM::tunnel_...

2016-06-15 Thread yatsukhnenko
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/700 @oknet, no, this isn't helping. It looks like cache write consumer tries to complete reading data from transformation but server_session already closed because transformation reads da

[GitHub] trafficserver issue #644: [TS 4437] Add new limit rate example plugin

2016-06-15 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/644 Sorry for the delay. Would you mind squashing this down to just one commit as well please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #644: [TS 4437] Add new limit rate example plugin

2016-06-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/644 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/287/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #644: [TS 4437] Add new limit rate example plugin

2016-06-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/644 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/179/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #644: [TS 4437] Add new limit rate example plugin

2016-06-15 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/644 [approve ci] Doing a fresh build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] trafficserver issue #644: [TS 4437] Add new limit rate example plugin

2016-06-15 Thread yatsukhnenko
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/644 @zwoop, could you have a time to look closer at this PR? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

Re: [VOTE] Release Apache Traffic Server 6.2.0 (RC0)

2016-06-15 Thread Phil Sorber
This vote has failed. We will address a number of bugs that have been identified as blockers and prepare a new RC. Thanks. On Tue, Jun 14, 2016 at 10:35 AM Bryan Call wrote: > -1 - Running this release in production I am seeing ASAN issues and there > is a problem with lots of error messages go

[GitHub] trafficserver pull request #689: TS-4424: ASAN heap-buffer-overflow

2016-06-15 Thread shinrich
Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/689 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] trafficserver issue #689: TS-4424: ASAN heap-buffer-overflow

2016-06-15 Thread shinrich
Github user shinrich commented on the issue: https://github.com/apache/trafficserver/pull/689 Closing. Turns out the issue was due to openssl version change. See Jira comments for details. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request #703: [TS-4529] Adjust thread with the right cont...

2016-06-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/703 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #711: TS-4527: Removing unneeded do_io_read and d...

2016-06-15 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/711 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-15 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/692 Ok, so I have reviewed this, and I'm happy with it. At the risk of bike shedding, I'm throwing in some thoughts on coding style here. It's entirely up to you if you feel it worth changing or not

[GitHub] trafficserver issue #718: TS-4543: Fix core in HttpSM::tunnel_handler_post.

2016-06-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/718 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/178/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #718: TS-4543: Fix core in HttpSM::tunnel_handler_post.

2016-06-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/718 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/286/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver pull request #718: TS-4543: Fix core in HttpSM::tunnel_handler...

2016-06-15 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/718 TS-4543: Fix core in HttpSM::tunnel_handler_post. You can merge this pull request into a Git repository by running: $ git pull https://github.com/shinrich/trafficserver ts-4543 Altern

[GitHub] trafficserver issue #717: TS-4507: Fixes to ensure SSN_CLOSE called after TX...

2016-06-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/717 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/285/ for details. --- If your project is set up for it, you can reply to this email and have your r

[GitHub] trafficserver issue #717: TS-4507: Fixes to ensure SSN_CLOSE called after TX...

2016-06-15 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/717 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/177/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver pull request #717: TS-4507: Fixes to ensure SSN_CLOSE called a...

2016-06-15 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/717 TS-4507: Fixes to ensure SSN_CLOSE called after TXN_CLOSE. Adding logic to ensure that SSN_CLOSE doesn't get called before TXN_CLOSE. This involved deferring the session destroy further. Ha