[GitHub] trafficserver pull request #677: TS-4189: Add tests for HPACK

2016-06-03 Thread maskit
Github user maskit closed the pull request at: https://github.com/apache/trafficserver/pull/677 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-03 Thread jacksontj
Github user jacksontj commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r65796064 --- Diff: iocore/hostdb/HostDB.cc --- @@ -1593,29 +1437,21 @@ HostDBContinuation::dnsEvent(int event, HostEnt *e) }

[GitHub] trafficserver issue #677: TS-4189: Add tests for HPACK

2016-06-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/677 Built and tested on the CI. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] trafficserver issue #686: TS-4496: Remove ink_code_md5_stringify

2016-06-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/686 Passed builds and test on the CI. https://ci.trafficserver.apache.org/view/github/job/Github-Linux/49/ https://ci.trafficserver.apache.org/view/github/job/Github-FreeBSD/37/ --- If

[GitHub] trafficserver issue #692: [TS-4500] add cookie-rewrite functionality into he...

2016-06-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/692 This passes build tests on the CI https://ci.trafficserver.apache.org/view/github/job/Github-Linux/48/ https://ci.trafficserver.apache.org/view/github/job/Github-FreeBSD/36/

[GitHub] trafficserver pull request #685: TS-4497: fix fetch api to release async ite...

2016-06-03 Thread shukitchan
Github user shukitchan closed the pull request at: https://github.com/apache/trafficserver/pull/685 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] trafficserver pull request #690: TS-4498: Enhanced the error message appeari...

2016-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/690 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #681: TS-4491: support sha256 and sha512 in ts_lu...

2016-06-03 Thread shukitchan
Github user shukitchan closed the pull request at: https://github.com/apache/trafficserver/pull/681 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] trafficserver issue #681: TS-4491: support sha256 and sha512 in ts_lua

2016-06-03 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/681 I am now thinking using luacrypto is a better choice. Closing for now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] trafficserver pull request #618: [TS-4408] Make volume.config not order sens...

2016-06-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/618 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-03 Thread jacksontj
Github user jacksontj commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r65780659 --- Diff: iocore/hostdb/I_HostDBProcessor.h --- @@ -139,10 +138,49 @@ struct SRVInfo { unsigned int key; }; -struct HostDBInfo {

[GitHub] trafficserver issue #653: TS-4331: Major re-write of hostdb

2016-06-03 Thread jacksontj
Github user jacksontj commented on the issue: https://github.com/apache/trafficserver/pull/653 @SolidWallOfCode yea, unless there is a reason to maintain multiple maps (for ipv4 vs ipv6) i'd leave them all together since they aren't causing any problems --- If your project is set up

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-03 Thread jacksontj
Github user jacksontj commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r65779442 --- Diff: iocore/hostdb/HostDB.cc --- @@ -439,37 +327,24 @@ HostDBCache::start(int flags) Warning("Please set 'proxy.config.hostdb.storage_pa

[GitHub] trafficserver issue #690: TS-4498: Enhanced the error message appearing in d...

2016-06-03 Thread pbchou
Github user pbchou commented on the issue: https://github.com/apache/trafficserver/pull/690 Made recommended fixes detailed in the comment above from @jpeach. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-03 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r65767037 --- Diff: iocore/hostdb/I_HostDBProcessor.h --- @@ -139,10 +138,49 @@ struct SRVInfo { unsigned int key; }; -struct HostDB

Question on recommended ATS release and update on SSLNetVConnection IOBufferBlock management issue

2016-06-03 Thread Craig Schomburg (craigs)
Leif and Susan, Based on your knowledge of the releases 6.0.0 and beyond, if we were looking at the best blessed release so far would you recommend looking at 6.1.1 (last posted release on the web site) or is there a 6.2 that is blessed as stable and deployed that would be a better option?

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-03 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r65764116 --- Diff: iocore/hostdb/HostDB.cc --- @@ -1593,29 +1437,21 @@ HostDBContinuation::dnsEvent(int event, HostEnt *e) }

[GitHub] trafficserver pull request #653: TS-4331: Major re-write of hostdb

2016-06-03 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/653#discussion_r65763754 --- Diff: iocore/hostdb/HostDB.cc --- @@ -1593,29 +1435,22 @@ HostDBContinuation::dnsEvent(int event, HostEnt *e) }

[GitHub] trafficserver issue #618: [TS-4408] Make volume.config not order sensitive.

2016-06-03 Thread calavera
Github user calavera commented on the issue: https://github.com/apache/trafficserver/pull/618 @jpeach sounds good to me. I can open a new pull request using that api. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] trafficserver issue #618: [TS-4408] Make volume.config not order sensitive.

2016-06-03 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/618 I did an initial review and some light testing of this. @calavera the API I was referring to is ``parseConfigLine`` from ``MatcherUtils.cc``. It is not quite a generic parser but it wil