[GitHub] trafficserver pull request: TS-4497: fix fetch api to release async item soo...

2016-05-31 Thread shukitchan
GitHub user shukitchan opened a pull request: https://github.com/apache/trafficserver/pull/685 TS-4497: fix fetch api to release async item sooner @sudheerv this is what we have been discussing for a while. With TS-3777, the ts.fetch() of ts_lua is no longer working fine. I finally

[GitHub] trafficserver pull request: Update configure.ac

2016-05-31 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/679 ``build/.aux`` is another possibility, though as I mentioned above, I'm OK with ``ts_aux`` too. Please also change it in ``.gitignore``. --- If your project is set up for it, you can re

[GitHub] trafficserver pull request: Update configure.ac

2016-05-31 Thread dragon512
Github user dragon512 commented on the pull request: https://github.com/apache/trafficserver/pull/679 Honestly I would use _aux myself. Allen said somebody hates _ so i made it ts_aux. honestly it does not matter it just cannot be prn, aux, or con It is useful for "generated"

[GitHub] trafficserver pull request: TS-4494: Replace ink_code_md5_stringify to ink_c...

2016-05-31 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/684 Yes! I'll file another JIRA tickets for it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] trafficserver pull request: TS-4494: Replace ink_code_md5_stringify to ink_c...

2016-05-31 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/684 If it's broken, we should either fix it, or remove it and use something that works :) --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] trafficserver pull request: TS-4494: Replace ink_code_md5_stringify to ink_c...

2016-05-31 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/684 Let's remove ``ink_code_md5_stringify``? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] trafficserver pull request: TS-4494: Replace ink_code_md5_stringify to ink_c...

2016-05-31 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/684 TS-4494: Replace ink_code_md5_stringify to ink_code_to_hex_str - [TS-4494](https://issues.apache.org/jira/browse/TS-4494) - It looks like `ink_code_md5_stringify` is broken. So using `

[GitHub] trafficserver pull request: TS-4309: Fix missing event setting that was caus...

2016-05-31 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/683 Yeah, been running on the docs site for a while, no issues. I also ran it on the Github Jenkins and passes all tests. https://ci.trafficserver.apache.org/job/Github-Linux/46/ --

[GitHub] trafficserver pull request: TS-4309: Fix missing event setting that was caus...

2016-05-31 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/683 Ship it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and w

[GitHub] trafficserver pull request: TS-4309: Fix missing event setting that was caus...

2016-05-31 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/683 TS-4309: Fix missing event setting that was causing a spin if a end o… …f SSL stream occurred due to ERR_SYSCALL. Also fixes clang warning described in TS-4492. You can merge t

[GitHub] trafficserver pull request: TS-4490: Prevent regression test from always run...

2016-05-31 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/680 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Jira's and commit

2016-05-31 Thread Leif Hedstrom
A reminder: Nothing has changed (so far) with regards to Jira’s. All non-trivial (i.e. other than typo’s, or docs fixes) commits must have a Jira number associated with it. And the commit messages *must* include this Jira number, e.g. TS-1234 Fixes the crashes introduced by ABCDEF123467

[GitHub] trafficserver pull request: TS-4489: Remove second calling of Http2Connectio...

2016-05-31 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/682 TS-4489: Remove second calling of Http2ConnectionState::delete_stream in Http2Stream::do_io_close [TS-4489](https://issues.apache.org/jira/browse/TS-4489) You can merge this pull request

[GitHub] trafficserver pull request: Update configure.ac

2016-05-31 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/679 I'll squash it when I commit it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] trafficserver pull request: Update configure.ac

2016-05-31 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/679 I can live with ts_aux :) > On May 31, 2016, at 11:16 AM, Leif Hedstrom wrote: > > Meh, ts_aux seemed to be a more recognizable name to me, why are we convoluting this

[GitHub] trafficserver pull request: Update configure.ac

2016-05-31 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/679 At least squash this down to one commit, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

Re: SSLNetVConnection IOBufferBlock management issue

2016-05-31 Thread Craig Schomburg (craigs)
On 5/31/16, 11:22 AM, "Susan Hinrichs" wrote: >Craig, > >Of the bugs you listed below, I'd only look at TS-4309. There are still >some issues there that oknet points out. But that might be easier to >debug. If nothing else, your initial read shouldn't be limited to 125 >bytes. The ini

[GitHub] trafficserver pull request: Update configure.ac

2016-05-31 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/679 Meh, ts_aux seemed to be a more recognizable name to me, why are we convoluting this just because one person hates underscores? --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: Update configure.ac

2016-05-31 Thread dragon512
Github user dragon512 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/679#discussion_r65234405 --- Diff: configure.ac --- @@ -37,7 +37,7 @@ m4_define([TS_VERSION_N],[700]) AC_INIT([Apache Traffic Server], TS_VERSION_S(), [dev@tra

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/681 These are just convenient and frequently used so we pulled them in instead of telling user to use external library. --- If your project is set up for it, you can reply to this emai

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/681#discussion_r65225001 --- Diff: doc/admin-guide/plugins/ts_lua.en.rst --- @@ -2107,6 +2107,85 @@ Here is an example: bin = ts.sha1_bin(uri) end

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/681#discussion_r65224725 --- Diff: plugins/experimental/ts_lua/ts_lua_crypto.c --- @@ -23,13 +23,21 @@ #define TS_LUA_MD5_DIGEST_LENGTH 16 #define TS_LUA_SHA_

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/681#discussion_r65224696 --- Diff: plugins/experimental/ts_lua/ts_lua_crypto.c --- @@ -23,13 +23,21 @@ #define TS_LUA_MD5_DIGEST_LENGTH 16 #define TS_LUA_SHA_

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/681#discussion_r65223795 --- Diff: plugins/experimental/ts_lua/ts_lua_crypto.c --- @@ -198,6 +222,130 @@ ts_lua_sha1_bin(lua_State *L) } static int +ts_lua_sh

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/681#discussion_r65223667 --- Diff: doc/admin-guide/plugins/ts_lua.en.rst --- @@ -2107,6 +2107,85 @@ Here is an example: bin = ts.sha1_bin(uri) end

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/681 It seems like [luacrypto](http://luacrypto.luaforge.net/manual.html) already gives pretty good access to the ``OpenSSL`` hash APIs. Do we need to duplicate that? --- If your project is

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/681#discussion_r65222759 --- Diff: plugins/experimental/ts_lua/ts_lua_crypto.c --- @@ -23,13 +23,21 @@ #define TS_LUA_MD5_DIGEST_LENGTH 16 #define TS_LUA_SHA_DIGE

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/681#discussion_r65222800 --- Diff: plugins/experimental/ts_lua/ts_lua_crypto.c --- @@ -23,13 +23,21 @@ #define TS_LUA_MD5_DIGEST_LENGTH 16 #define TS_LUA_SHA_DIGE

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/681 @jpeach this one should be simple. would appreciate if you can take a quick look and see if there is any trivial thing i miss. thanks. --- If your project is set up for it, you can

[GitHub] trafficserver pull request: C++ API WebSocket example

2016-05-31 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/624 @ogoodman would you mind also starting a thread on dev@trafficserver.apache.org for API review? I can also kick off this discussion if you'd like. --- If your project is set up for it,

[GitHub] trafficserver pull request: TS-4491: support sha256 and sha512 in ts_lua

2016-05-31 Thread shukitchan
GitHub user shukitchan opened a pull request: https://github.com/apache/trafficserver/pull/681 TS-4491: support sha256 and sha512 in ts_lua support sha256 and sha512 in ts_lua plugin You can merge this pull request into a Git repository by running: $ git pull https://github.co

[GitHub] trafficserver pull request: C++ API WebSocket example

2016-05-31 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/624 @bgaff The new API should go through API review. IMHO it would be best to make a separate JIRA and pull request for the API changes. --- If your project is set up for it, you can reply

[GitHub] trafficserver pull request: TS-4490: Prevent regression test from always run...

2016-05-31 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/680 TS-4490: Prevent regression test from always running. If we default the regression level to QUICK, then they always run. Default the level to NONE and remove default parameters to make it

[GitHub] trafficserver pull request: TS-4490: Prevent regression test from always run...

2016-05-31 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/680 cc @maskit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver pull request: C++ API WebSocket example

2016-05-31 Thread shukitchan
Github user shukitchan commented on the pull request: https://github.com/apache/trafficserver/pull/624 also is there a jira ticket for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] trafficserver pull request: C++ API WebSocket example

2016-05-31 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/624 Hi @ogoodman , I want to get this landed soon can you please just make one final change which puts it under an experimental/ folder in examples? After that I'm happy to commit this for yo

[GitHub] trafficserver pull request: TS-4189: Add tests for HPACK

2016-05-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/677#discussion_r65215059 --- Diff: proxy/http2/test_HPACK.cc --- @@ -0,0 +1,413 @@ +/** @file + +Test runner for HPACK encoding and decoding. + +@sect

[GitHub] trafficserver pull request: TS-4428: Update Japanese documentations

2016-05-31 Thread PSUdaemon
Github user PSUdaemon closed the pull request at: https://github.com/apache/trafficserver/pull/678 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: TS-4428: Update Japanese documentations

2016-05-31 Thread PSUdaemon
Github user PSUdaemon commented on the pull request: https://github.com/apache/trafficserver/pull/678 Weird. I get `error: could not apply 1f4a810... Doc: Format po files` when I do the cherry pick. But this is fine, I'll just merge this. Thanks. --- If your project is set u

[GitHub] trafficserver pull request: TS-4189: Add tests for HPACK

2016-05-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/677#discussion_r65211796 --- Diff: proxy/http2/test_HPACK.cc --- @@ -0,0 +1,413 @@ +/** @file + +Test runner for HPACK encoding and decoding. + +@sect

[GitHub] trafficserver pull request: Update configure.ac

2016-05-31 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/679#discussion_r65211314 --- Diff: configure.ac --- @@ -37,7 +37,7 @@ m4_define([TS_VERSION_N],[700]) AC_INIT([Apache Traffic Server], TS_VERSION_S(), [dev@traffi

[GitHub] trafficserver pull request: Update configure.ac

2016-05-31 Thread dragon512
GitHub user dragon512 opened a pull request: https://github.com/apache/trafficserver/pull/679 Update configure.ac Change "aux" directory to a value that does not upset systems that use this value as a device name for legacy purposes You can merge this pull request into a Git reposi

Re: SSLNetVConnection IOBufferBlock management issue

2016-05-31 Thread Susan Hinrichs
Craig, Of the bugs you listed below, I'd only look at TS-4309. There are still some issues there that oknet points out. But that might be easier to debug. If nothing else, your initial read shouldn't be limited to 125 bytes. Looked more closely at your debug output again. Is this the fir

[GitHub] trafficserver pull request: TS-4428: Update Japanese documentations

2016-05-31 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/678 @PSUdaemon I didn't see any conflicts but I hope this helps you backport the commits. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] trafficserver pull request: TS-4428: Update Japanese documentations

2016-05-31 Thread maskit
GitHub user maskit opened a pull request: https://github.com/apache/trafficserver/pull/678 TS-4428: Update Japanese documentations Cherry pick 95355d8434deed3e8a222effa86eb7c3c11082bc..6c6b6bc50f80959484e96dda8aa87f28bbf6e086 from master for 6.2.x You can merge this pull request i

[GitHub] trafficserver pull request: [TS-4488] fix Segmentation fault at HttpSM::tunn...

2016-05-31 Thread yatsukhnenko
Github user yatsukhnenko closed the pull request at: https://github.com/apache/trafficserver/pull/674 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] trafficserver pull request: [TS-4488] fix Segmentation fault at HttpSM::tunn...

2016-05-31 Thread yatsukhnenko
Github user yatsukhnenko commented on the pull request: https://github.com/apache/trafficserver/pull/674 Yet another trace ``` #0 0x00503cb4 in HttpServerSession::get_netvc (this=0x0) at ./http/HttpServerSession.h:113 #1 0x005653e9 in HttpSM::tunnel_handle

Re: SSLNetVConnection IOBufferBlock management issue

2016-05-31 Thread Alan Carroll
TS-4260 isn't ready to ship yet, so you don't want that. TS-4309 is useful but only fixes an issue that arises due to timing changes from TS-4260. I'm not sure about the other two. On Tuesday, May 31, 2016 9:12 AM, Craig Schomburg (craigs) wrote: Susan, - TS-4309 Reduced SSL upload/downlo

Re: SSLNetVConnection IOBufferBlock management issue

2016-05-31 Thread Alan Carroll
Ah, that's just a limit on write though. All writing needs to happen at the first available byte so it is naturally constrained. The second block is checked only so that if the first block is full a new block is *not* allocated until it is needed. For this same reason it should never be the case

Re: SSLNetVConnection IOBufferBlock management issue

2016-05-31 Thread Craig Schomburg (craigs)
Susan, Have a few questions in trying to determine what direction we need to go from our end on our issue. Due to our pre-release test cycle time we are currently prepared to ship our next product update using the ATS 6.0.0 code base. Unfortunately we do not have the test window to move to a

[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-31 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/666#issuecomment-222639026 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] trafficserver pull request: remove typo line at aio_queue_req

2016-05-31 Thread maskit
Github user maskit closed the pull request at: https://github.com/apache/trafficserver/pull/676 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4189: Add tests for HPACK

2016-05-31 Thread maskit
GitHub user maskit opened a pull request: https://github.com/apache/trafficserver/pull/677 TS-4189: Add tests for HPACK https://issues.apache.org/jira/browse/TS-4189 The test cases come from: https://github.com/http2jp/hpack-test-case https://github.com/http2/http_sa

[GitHub] trafficserver pull request: remove typo line at aio_queue_req

2016-05-31 Thread dark264sh
GitHub user dark264sh opened a pull request: https://github.com/apache/trafficserver/pull/676 remove typo line at aio_queue_req You can merge this pull request into a Git repository by running: $ git pull https://github.com/dark264sh/trafficserver remove_typo_line Alternative