atscppapi question

2016-05-26 Thread Dk Jack
Hi, I am using atscppapi in my plugin. I send a curl request as follows to ATS: curl 'http://localhost:8080/abcdef?a=1&b=2' In my plugin code, in handleReadRequestHeadersPreRemap function, I am printing the following: logInfo("effective-url: %s", txn.getEffectiveUrl().c_str()); ClientReques

[GitHub] trafficserver pull request: Fix ParentProxySet configuration race.

2016-05-26 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/671 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4469: TS-3612 restructuring issues ...

2016-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/657 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-222003637 Merged up with commit 456ade9ab35787d39d3414149a0ee04f44008268 --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread shinrich
Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/669 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] trafficserver pull request: TS-4485 schedule HostDBSyncer in ET_TA...

2016-05-26 Thread jacksontj
Github user jacksontj closed the pull request at: https://github.com/apache/trafficserver/pull/670 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: TS-4486: Add release to MutexLock.

2016-05-26 Thread shinrich
Github user shinrich closed the pull request at: https://github.com/apache/trafficserver/pull/672 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] trafficserver pull request: TS-4486: Add release to MutexLock.

2016-05-26 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/672#issuecomment-221991671 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] trafficserver pull request: Fix ParentProxySet configuration race.

2016-05-26 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/671#issuecomment-221972130 https://ci.trafficserver.apache.org/view/github/job/Github-Linux/41/ --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] trafficserver pull request: Fix ParentProxySet configuration race.

2016-05-26 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/671#issuecomment-221971918 Failed the clang-format tests :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] trafficserver pull request: TS-4486: Add release to MutexLock.

2016-05-26 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/672 TS-4486: Add release to MutexLock. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SolidWallOfCode/trafficserver ts-4486 Alterna

[GitHub] trafficserver pull request: Fix ParentProxySet configuration race.

2016-05-26 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/671#issuecomment-221960661 https://ci.trafficserver.apache.org/view/github/job/Github-Linux/40/ --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] trafficserver pull request: Fix ParentProxySet configuration race.

2016-05-26 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/671 Fix ParentProxySet configuration race. The first part of the problem occurs because the HTTP state machine samples the parent proxy configuration at the start of a transaction. We have

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread shinrich
Github user shinrich commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/669#discussion_r64788248 --- Diff: proxy/http/Http1ClientSession.cc --- @@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction *trans) ka_vio = this-

[GitHub] trafficserver pull request: TS-4485 schedule HostDBSyncer in ET_TA...

2016-05-26 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/670#issuecomment-221939799 Ship it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread bryancall
Github user bryancall commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/669#discussion_r64785961 --- Diff: proxy/http/Http1ClientSession.cc --- @@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction *trans) ka_vio = this

[GitHub] trafficserver pull request: [TS-4379] Add log field for Server Con...

2016-05-26 Thread ericcarlschwartz
Github user ericcarlschwartz closed the pull request at: https://github.com/apache/trafficserver/pull/598 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-221936130 Cool. Can you mark the Jira with back port to 6.1.2 as well as 6.2.0 please? I'll try to spend some time today and tomorrow to see what we should get into a potenti

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-221935663 I went through all the changes with Susan and I will +1 these changes. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-221935540 Based on my research it would be an issue for 6.0 and 6.1 as well. TS-3727 change was marked fixed for 6.0. --- If your project is set up for it, you can rep

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/669#discussion_r64783870 --- Diff: proxy/http/Http1ClientSession.cc --- @@ -427,9 +427,12 @@ Http1ClientSession::release(ProxyClientTransaction *trans) ka_vio

[GitHub] trafficserver pull request: TS-4483: NetAccept & SSLNetAccept Opti...

2016-05-26 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/665#issuecomment-221927587 Ya, I believe the idea was to eliminate ET_SSL for 7.0.0. See https://issues.apache.org/jira/browse/TS-3046. --- If your project is set up for it, you can reply to

[GitHub] trafficserver pull request: TS-4461: SSL Client Connections not cl...

2016-05-26 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/669#issuecomment-221927293 @shinrich The Jira vs this PR has slightly different implications :). Is this a 6.0 issue (i.e. would 6.1.x be affected by this) or is it only in 6.2.x ? I'm contem

[GitHub] trafficserver pull request: TS-4485 schedule HostDBSyncer in ET_TA...

2016-05-26 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/670#issuecomment-221927039 @zwoop I have a rewrite of hostdb #653 which actually solves all known issues with hostdb (not to mention a significant complexity decrease, and test coverage i

[GitHub] trafficserver pull request: TS-4485 schedule HostDBSyncer in ET_TA...

2016-05-26 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/670#issuecomment-221925952 Maybe we should make the default in 7.0.0 to not sync HostDB at all. I don't know about the back port to 6.2.x, that's something for @PSUdaemon to consider though

[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...

2016-05-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/646 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4483: NetAccept & SSLNetAccept Opti...

2016-05-26 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/665#issuecomment-221896248 Yes, I know it is still there. Just bringing up the broader issue since you are working in that area anyway. @zwoop and @SolidWallOfCode am I remembering corre

[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-26 Thread jsime
Github user jsime commented on the pull request: https://github.com/apache/trafficserver/pull/666#issuecomment-221890278 Thanks for the catches. Fixed that 'i' typo and I switched the full URL in the comment at the top of records.config.default.in over to the shortened version. The li

[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-26 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/666#issuecomment-221816974 Some URLs are shorten. They should be unified? e.g. https://docs.trafficserver.apache.org/records.config#thread-variables https://docs.trafficserve

[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-26 Thread maskit
Github user maskit commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/666#discussion_r64710906 --- Diff: proxy/config/records.config.default.in --- @@ -15,12 +15,11 @@ CONFIG proxy.config.ssl.number.threads INT -1 CONFIG proxy.config.accept_th