[GitHub] trafficserver pull request: TS-4485 schedule HostDBSyncer in ET_TA...

2016-05-25 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/670 TS-4485 schedule HostDBSyncer in ET_TASK threads instead of ET_NET threads Since the syncer is on ET_NET threads this effectively means every sync interval an ET_NET thread is blocked howev

[GitHub] trafficserver pull request: TS-4483: NetAccept & SSLNetAccept Opti...

2016-05-25 Thread oknet
Github user oknet commented on the pull request: https://github.com/apache/trafficserver/pull/665#issuecomment-22179 @shinrich ET_SSL is still here. SSLNetAccept::etype is set to ET_SSL by sslNetProcessor::upgradeEtype(). --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: NetAccept & SSLNetAccept Optimize, rep...

2016-05-25 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/665#issuecomment-221761867 I thought we were getting rid of the SSL threads (and thus ET_SSL). If so, we could probably do some more simplification here. --- If your project is set up fo

[GitHub] trafficserver pull request: TS-4661: SSL Client Connections not cl...

2016-05-25 Thread shinrich
GitHub user shinrich opened a pull request: https://github.com/apache/trafficserver/pull/669 TS-4661: SSL Client Connections not closed. Ultimately the issue was that SSL connections that stall in the ProtocolTrampoline never have the inactivity timeout cleanup. The problem was in

[GitHub] trafficserver pull request: TS-4367: Failed clang-analyzer, memory...

2016-05-25 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/668 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: TS-4367: Failed clang-analyzer, memory...

2016-05-25 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/668#issuecomment-221726539 Looks good to me, but not tested with clang-analyzer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request: TS-4367: Failed clang-analyzer, memory...

2016-05-25 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/668#issuecomment-221726392 This builds and runs on the CI without problems. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] trafficserver pull request: Clang-analyzer failure, Called C++ obj...

2016-05-25 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/667 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: TS-4367: Failed clang-analyzer, memory...

2016-05-25 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/668 TS-4367: Failed clang-analyzer, memory leak in mgmt/api You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver clang2

[GitHub] trafficserver pull request: Clang-analyzer failure, Called C++ obj...

2016-05-25 Thread bryancall
GitHub user bryancall opened a pull request: https://github.com/apache/trafficserver/pull/667 Clang-analyzer failure, Called C++ object pointer is null You can merge this pull request into a Git repository by running: $ git pull https://github.com/bryancall/trafficserver clang

[GitHub] trafficserver pull request: NetAccept & SSLNetAccept Optimize, rep...

2016-05-25 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/665#issuecomment-221613806 Cool. Can you rename Subject line for this PR to include the Jira # please? --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] trafficserver pull request: NetAccept & SSLNetAccept Optimize, rep...

2016-05-25 Thread oknet
Github user oknet commented on the pull request: https://github.com/apache/trafficserver/pull/665#issuecomment-221612012 Sorry, forget to create it, please link to TS-4483. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] trafficserver pull request: TS-4377: update documentation links in...

2016-05-25 Thread jsime
GitHub user jsime opened a pull request: https://github.com/apache/trafficserver/pull/666 TS-4377: update documentation links in default configuration files - Updates existing links in default configuration files to point to current Administrator's Guide documentation URLs. - Ad

[GitHub] trafficserver pull request: NetAccept & SSLNetAccept Optimize, rep...

2016-05-25 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/665#issuecomment-221595494 What's the Jira # for this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver pull request: TS-4481: CPP API - clear handles and r...

2016-05-25 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/663#issuecomment-221594976 Sounds good. Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] trafficserver pull request: TS-4481: CPP API - clear handles and r...

2016-05-25 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/663#issuecomment-221594161 Unfortunately `event_` is actually used in `Transaction::initCachedRequest` to do handle initialization differently for `TS_EVENT_HTTP_TXN_CLOSE`. I don't

[GitHub] trafficserver pull request: [TS 4437] Add new limit rate example p...

2016-05-25 Thread yatsukhnenko
Github user yatsukhnenko commented on the pull request: https://github.com/apache/trafficserver/pull/644#issuecomment-221572657 I need some help for fixing unexpected Segmentation fault. ``` NOTE: Traffic Server received Sig 11: Segmentation fault /opt/trafficserver-4.2.3/bi

[GitHub] trafficserver pull request: NetAccept & SSLNetAccept Optimize, rep...

2016-05-25 Thread oknet
GitHub user oknet opened a pull request: https://github.com/apache/trafficserver/pull/665 NetAccept & SSLNetAccept Optimize, replace getEtype() with member etype. You can merge this pull request into a Git repository by running: $ git pull https://github.com/oknet/trafficserve

[GitHub] trafficserver pull request: TS-4482: To freely output to custom lo...

2016-05-25 Thread yishimur
GitHub user yishimur opened a pull request: https://github.com/apache/trafficserver/pull/664 TS-4482: To freely output to custom log Modify the contents are as follows: * add note field on logging * add CPP API functions named noteStringSet / Get * add StringHashMap on li