[GitHub] trafficserver pull request: TS-4466: Add links to other versions o...

2016-05-24 Thread jsime
Github user jsime closed the pull request at: https://github.com/apache/trafficserver/pull/654 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] trafficserver pull request: TS-4481: CPP API - clear handles and r...

2016-05-24 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/663#issuecomment-221442464 Fwiw I think it might make sense to fully remove event_, nothing really needs it. It just helps when debugging if you couldn't get a handle to a request/response ob

[GitHub] trafficserver pull request: TS-4481: CPP API - clear handles and r...

2016-05-24 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/663 TS-4481: CPP API - clear handles and reload on demand. The changes are * The handles are cleared, not re-initialized, per hook. * Handles are loaded from the transaction o

[GitHub] trafficserver pull request: TS-3959: requests are retryable only i...

2016-05-24 Thread jacksontj
Github user jacksontj closed the pull request at: https://github.com/apache/trafficserver/pull/658 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: TS-4477: Decrement http_current_client...

2016-05-24 Thread bryancall
Github user bryancall closed the pull request at: https://github.com/apache/trafficserver/pull/662 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] trafficserver pull request: TS-4477: Decrement http_current_client...

2016-05-24 Thread bryancall
Github user bryancall commented on the pull request: https://github.com/apache/trafficserver/pull/662#issuecomment-221350082 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver pull request: TS-4108: Switch SSL metrics to RECD_CO...

2016-05-24 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/661 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4477: Decrement http_current_client...

2016-05-24 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/662 TS-4477: Decrement http_current_client_transactions_stat in HTTP/2 [TS-4477](https://issues.apache.org/jira/browse/TS-4477) You can merge this pull request into a Git repository by running

[GitHub] trafficserver pull request: TS-4108: Switch SSL metrics to RECD_CO...

2016-05-24 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/661#issuecomment-221328309 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

[GitHub] trafficserver pull request: TS-4108: Switch SSL metrics to RECD_CO...

2016-05-24 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/661 TS-4108: Switch SSL metrics to RECD_COUNTER. All the SSL metrics registered in SSLUtils.cc are specified as RECD_INT, but they are all actually counters and should be specified as RECD_

[GitHub] trafficserver pull request: TS-3959: requests are retryable only i...

2016-05-24 Thread SolidWallOfCode
Github user SolidWallOfCode commented on the pull request: https://github.com/apache/trafficserver/pull/658#issuecomment-221296297 This looks like a good change, because `server_request_hdr_bytes` gets set on scheduling the initial write and not when the bytes are actually written, so

[GitHub] trafficserver pull request: TS-4466: Add links to other versions o...

2016-05-24 Thread maskit
Github user maskit commented on the pull request: https://github.com/apache/trafficserver/pull/654#issuecomment-221186963 Thank you for pointing out the issue. I found a fix for it on RTD's repository. https://github.com/rtfd/readthedocs.org/commit/b15d50bc200677053c04f6ede6c72fd1