[GitHub] trafficserver pull request: TS-4448 Remove superfluous \n in Debug...

2016-05-19 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/652 TS-4448 Remove superfluous \n in Debug() statements Debug() will check for this anyways, so for consistency, we should remove these since it sets a better precedence going forward. You can mer

[GitHub] trafficserver pull request: TS-3607: Integrate ats_pagespeed into ...

2016-05-19 Thread caguado
Github user caguado commented on the pull request: https://github.com/apache/trafficserver/pull/210#issuecomment-220460158 Rebased against current 5.3.x and passed clang-format. @jpeach, please let me know whether this is what you had in mind. --- If your project is set up fo

[GitHub] trafficserver pull request: TS-4462: Clean up pending_action for T...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/649 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4462: Clean up pending_action for T...

2016-05-19 Thread silentdai
Github user silentdai commented on the pull request: https://github.com/apache/trafficserver/pull/649#issuecomment-220442827 I love this solution. I built with this commit. It avoids the crash when resuming the HttpSM from a plugin working in POST_REMAP phase if the cache is disabled.

[GitHub] trafficserver pull request: TS-4462: Clean up pending_action for T...

2016-05-19 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/649#issuecomment-220422969 Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] trafficserver pull request: TS-4458: disabling configuration modif...

2016-05-19 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/651 TS-4458: disabling configuration modification breaks reloading If you set ``proxy.config.disable_configuration_modification`` to 1, records configuration callbacks are never registered, so if

[GitHub] trafficserver pull request: TS-4458: disabling configuration modif...

2016-05-19 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/651#issuecomment-220421430 Ping @bcall --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4450: Syntax error in CI test

2016-05-19 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/650 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4450: Syntax error in CI test

2016-05-19 Thread dragon512
GitHub user dragon512 opened a pull request: https://github.com/apache/trafficserver/pull/650 TS-4450: Syntax error in CI test Fix extra ) that was in the list You can merge this pull request into a Git repository by running: $ git pull https://github.com/dragon512/trafficserve

[GitHub] trafficserver pull request: TS-4462: Clean up pending_action for T...

2016-05-19 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/649 TS-4462: Clean up pending_action for TSHttpSchedule. You can merge this pull request into a Git repository by running: $ git pull https://github.com/SolidWallOfCode/trafficserve

[GitHub] trafficserver pull request: TS-4460: Remove record conversion from...

2016-05-19 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/648 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4459 - Force domain names in cert t...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/647#issuecomment-220391391 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: [TS-4443] regex_remap: fix $i substitu...

2016-05-19 Thread yatsukhnenko
Github user yatsukhnenko commented on the pull request: https://github.com/apache/trafficserver/pull/643#issuecomment-220377419 You had to say [approve ci] 😉 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/632 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: UUID Proposal

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/199#issuecomment-220376347 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-3978: Allow empty document caching ...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/310#issuecomment-220376339 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4072 Diagnostic log rolling races

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/568#issuecomment-220376323 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-3607: Integrate ats_pagespeed into ...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/210#issuecomment-220376341 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: Added (Estimated) Round Trip Time acce...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/123#issuecomment-220376350 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/646#issuecomment-220376259 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-3245 : Changes optind = 1 to optind...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/571#issuecomment-220376319 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-220376299 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: AARCH64 fixes tested on Cavium Thunder...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/502#issuecomment-220376328 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/593#issuecomment-220376308 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: [TS-4103] mocks

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/408#issuecomment-220376332 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: [TS-4443] regex_remap: fix $i substitu...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/643#issuecomment-220376270 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/588#issuecomment-220376312 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: C++ API WebSocket example

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/624#issuecomment-220376297 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: Proposal: NetVC Context

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/642#issuecomment-220376284 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: [TS-4379] Add log field for Server Con...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/598#issuecomment-220376302 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: [TS 4437] Add new limit rate example p...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/644#issuecomment-220376265 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4459 - Force domain names in cert t...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/647#issuecomment-220376258 . --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4455: remove isEosRcvd() and eosRcv...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/646#issuecomment-220368272 I think we should squash these three commits to one, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] trafficserver pull request: TS-4460: Remove record conversion from...

2016-05-19 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/648#issuecomment-220365099 Testing new auth token. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav