Github user oknet commented on the pull request:
https://github.com/apache/trafficserver/pull/642#issuecomment-219936052
@SolidWallOfCode get_server_addr() and get_client_addr() is wrapper
functions only.
the wrapper function get_server_addr() is used to decide which variable
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/628
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sudheerv closed the pull request at:
https://github.com/apache/trafficserver/pull/645
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/638
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219873200
The TS-3612 commit resulted into significant restructuring resulting in new
issues or adjusting timing to reveal latent issues. I'll take a look at the
small po
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/645#issuecomment-219872657
This built and tested without problems on CI:
https://ci.trafficserver.apache.org/view/github/job/Github-Linux/81/
https://ci.trafficserver.apache.org/vi
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/645#issuecomment-219872749
+1 from me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
GitHub user sudheerv opened a pull request:
https://github.com/apache/trafficserver/pull/645
[TS-4452] Fix the type for open_write_fail_action to MgmtByte.
@zwoop pls review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sudheerv
Github user jacksontj commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/636#discussion_r63581211
--- Diff: proxy/http/HttpTransact.cc ---
@@ -3460,7 +3460,7 @@ HttpTransact::HandleStatPage(State *s)
s->hdr_info.client_response.value_set
Github user jacksontj closed the pull request at:
https://github.com/apache/trafficserver/pull/636
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featu
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/571#issuecomment-219788326
After doing more reading here and on the net, I now agree with @pbchou in
his original approach. Core should use `optind = 1` and all the plugins should
b
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/642#issuecomment-219751045
My point would be the need to carefully explain what the methods do in
different contexts is the problem. "Local" and "remote" are always clear and
need l
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/643#issuecomment-219728080
Since this is a "core" plugin, ats_ip_ntop() ought to be fine. It doesn't
require anything other than C++ and the #include file, right? @jpeach We
probably need to
Github user oknet commented on the pull request:
https://github.com/apache/trafficserver/pull/642#issuecomment-219642314
Currently, get_server_addr() and get_client_addr() implement as wrapper
functions to call get_local_addr() and get_remote_addr() depend on netvc
context. It is easy
14 matches
Mail list logo
