Github user yatsukhnenko commented on the pull request:
https://github.com/apache/trafficserver/pull/635#issuecomment-219356538
I didn't find a better way to pass the client-ip (TSHttpTxnClientAddrGet)
to RemapRegex::substitute routine without changing of number of routine
parameters
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-219347020
@zwoop done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feat
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-219342137
Can you squash the commits together too? We don't want intermediary commits
that are failing (they make git bisect difficult to deal with).
---
If your project is
Github user danobi commented on the pull request:
https://github.com/apache/trafficserver/pull/568#issuecomment-219324620
@zwoop I've gone ahead and done that. I don't know how (or if I can) to run
the CI builds so I'll just leave that to you.
---
If your project is set up for it, yo
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/635#issuecomment-219307477
I'm not sure I understand the full intent of this patch. It looks like it's
always adding the Client-IP header, even if not enabled in records.config? Why
is this n
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219303052
Passed CI build tests.
https://ci.trafficserver.apache.org/view/github/job/Github-FreeBSD/164/
https://ci.trafficserver.apache.org/view/github/job/Github
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/638#issuecomment-219303077
@shinrich Can you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/637
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user jpeach closed the pull request at:
https://github.com/apache/trafficserver/pull/641
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/639#issuecomment-219284857
This passed the build tests on the CI, see
https://ci.trafficserver.apache.org/view/github/job/Github-Linux/71/
https://ci.trafficserver.apache.org/view/
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/639#issuecomment-219284428
@shinrich Can you review this please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proje
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/262
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user zizhong commented on the pull request:
https://github.com/apache/trafficserver/pull/262#issuecomment-219270341
@zwoop , I noticed the code has been merged while this request is still
open.
About the clang-format failure, I checked the URL above and couldn't find
this p
13 matches
Mail list logo
