[GitHub] trafficserver pull request: TS-4439 Reimplement TSHttpTxnConfigFin...

2016-05-12 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/634#issuecomment-218960894 If you're going to use STL you should probably incorporate the stl allocators, or if we're going to settle on jemalloc then it doesn't matter --- If your project i

Re: [Feature request] Add configs to ignore server Cache-Control: max-age and Expires

2016-05-12 Thread Hiroaki Nakamura
Thanks for your comment. The following is my understanding of what you said. For example, I will ignore the max-age parameter and limit s-maxage to 60. If the response from origin server contains the headers like: < Cache-Control: s-maxage=180, max-age=360 Then I modify headers in READ_RESPONSE

[GitHub] trafficserver pull request: TS-4439 Reimplement TSHttpTxnConfigFin...

2016-05-12 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/634#issuecomment-218950857 Are we now okay with letting the use of STL in the core? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] trafficserver pull request: TS-4439 Reimplement TSHttpTxnConfigFin...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/634#issuecomment-218946224 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4439 Reimplement TSHttpTxnConfigFin...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/634#issuecomment-218945356 Yeah, this seems nicer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] trafficserver pull request: TS-4439 Reimplement TSHttpTxnConfigFin...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/634#issuecomment-218945321 Yeah, this seems nicer. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] trafficserver pull request: TS-4439 Reimplement TSHttpTxnConfigFin...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/634#issuecomment-218945006 Test response (manually). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] trafficserver pull request: TS-4439 Reimplement TSHttpTxnConfigFin...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/634#issuecomment-218944885 Just a test [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] trafficserver pull request: TS-4439 Reimplement TSHttpTxnConfigFin...

2016-05-12 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/634 TS-4439 Reimplement TSHttpTxnConfigFind This needs some cleanup (probably better names, and probably should move the PAIR struct out to the header file), but I want to get some feedback on

Re: [Feature request] Add configs to ignore server Cache-Control: max-age and Expires

2016-05-12 Thread Sudheer Vinukonda
blockquote, div.yahoo_quoted { margin-left: 0 !important; border-left:1px #715FFA solid !important; padding-left:1ex !important; background-color:white !important; } Hmm..it should be possible to do what you need with a plugin. For instance, going back to the solution you tried, perhaps you coul

Re: [Feature request] Add configs to ignore server Cache-Control: max-age and Expires

2016-05-12 Thread Hiroaki Nakamura
I tried and found that when I modify headers in TS_HTTP_READ_RESPONSE_HDR_HOOK, the cached object has those modified headers, so when the next time a request comes in, the cached response with the modified headers is served. This is not what I want. My requirement is to serve cached objects with t

[GitHub] trafficserver pull request: Ts 3612 - Restructuring client session...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/570#issuecomment-218931643 We should flag this for 6.2.0. Can you file a Jira please? @PSUdaemon --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver pull request: Ts 3612 - Restructuring client session...

2016-05-12 Thread calavera
Github user calavera commented on the pull request: https://github.com/apache/trafficserver/pull/570#issuecomment-218931181 @asfgit @jpeach I just want to leave a note here because we found an issue with this commit. Under certain circumstances ATS segfaults due to this changes. I hav

[GitHub] trafficserver pull request: TS-4274 Use the right hostdb levels as...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/536#issuecomment-218929370 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/588#issuecomment-218929156 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4072 Diagnostic log rolling races

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/568#issuecomment-218929112 Upgraded git on all the build boxes, so try again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] trafficserver pull request: TS-4274 Use the right hostdb levels as...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/536#issuecomment-218928854 Upgraded git on all the build boxes, so try again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] trafficserver pull request: TS-3245 : Changes optind = 1 to optind...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/571#issuecomment-218928614 Upgraded git on all the build boxes, so try again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitH

[GitHub] trafficserver pull request: TS-3245 : Changes optind = 1 to optind...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/571#issuecomment-218906249 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/19/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4274 Use the right hostdb levels as...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/536#issuecomment-218905592 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/18/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-3245 : Changes optind = 1 to optind...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/571#issuecomment-218905456 Linux (CentOS7) build failed! Details on https://ci.trafficserver.apache.org/job/Github-Linux/40/ --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: TS-4072 Diagnostic log rolling races

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/568#issuecomment-218905112 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/17/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-3245 : Changes optind = 1 to optind...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/571#issuecomment-218904513 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/16/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4072 Diagnostic log rolling races

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/568#issuecomment-218904299 Linux (CentOS7) build failed! Details on https://ci.trafficserver.apache.org/job/Github-Linux/34/ --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: TS-4274 Use the right hostdb levels as...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/536#issuecomment-218904303 Linux (CentOS7) build failed! Details on https://ci.trafficserver.apache.org/job/Github-Linux/35/ --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: TS-4274 Use the right hostdb levels as...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/536#issuecomment-218903932 @jacksontj Can you review this please? Also, lets do one more build for FBSD [approve ci]. --- If your project is set up for it, you can reply to this email and h

[GitHub] trafficserver pull request: TS-4072 Diagnostic log rolling races

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/568#issuecomment-218903748 One more round of builds [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] trafficserver pull request: TS-3245 : Changes optind = 1 to optind...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/571#issuecomment-218903158 Linux (CentOS7) build failed! Details on https://ci.trafficserver.apache.org/job/Github-Linux/33/ --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: TS-3245 : Changes optind = 1 to optind...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/571#issuecomment-218903058 Another build needed [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] trafficserver pull request: TS-3792: Crash with non-existant or mi...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/262#issuecomment-218902578 Can this be squashed into one commit? Or does it need to be split up like this? --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] trafficserver pull request: Converted Apache::TS::AdminClient to u...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/35#issuecomment-218902282 Should we close this PR for now ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] trafficserver pull request: [TS-4103] mocks

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/408#issuecomment-218901160 After the Summit, is this still a path we want to take? I'm not against this, just asking. --- If your project is set up for it, you can reply to this email and ha

[GitHub] trafficserver pull request: TS-4410 : Fixed compiler warning on i3...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/611#issuecomment-218900899 I think this is ready to land. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request: TS-4410 : Fixed compiler warning on i3...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/611#issuecomment-218900146 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/15/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4410 : Fixed compiler warning on i3...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/611#issuecomment-218900061 Linux (CentOS7) build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-Linux/32/ --- If your project is set up for it, you c

[GitHub] trafficserver pull request: TS-4410 : Fixed compiler warning on i3...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/611#issuecomment-218898115 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-2581: Standard library allocators a...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/622#issuecomment-218872975 @bgaff You want to just close this out for now, until we all test / verify the validity of turning off freelist in favor of just jemalloc ? --- If your project is

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63081400 --- Diff: proxy/http2/Http2DependencyTree.h --- @@ -0,0 +1,296 @@ +/** @file + + HTTP/2 Dependency Tree + + The original idea of Str

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63078730 --- Diff: proxy/http2/Http2ConnectionState.cc --- @@ -756,6 +773,15 @@ Http2ConnectionState::main_event_handler(int event, void *edata) return 0

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread masaori335
Github user masaori335 commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63078637 --- Diff: proxy/http2/HTTP2.h --- @@ -60,6 +60,10 @@ const uint32_t HTTP2_MAX_FRAME_SIZE = 16384; const uint32_t HTTP2_HEADER_TABLE_SIZE = 4096;

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63075928 --- Diff: proxy/http2/HTTP2.h --- @@ -60,6 +60,10 @@ const uint32_t HTTP2_MAX_FRAME_SIZE = 16384; const uint32_t HTTP2_HEADER_TABLE_SIZE = 4096;

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63075422 --- Diff: proxy/http2/HTTP2.cc --- @@ -681,6 +686,7 @@ Http2::init() REC_EstablishStaticConfigInt32U(max_concurrent_streams_in, "proxy.config.http

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63075156 --- Diff: mgmt/RecordsConfig.cc --- @@ -1976,6 +1976,8 @@ static const RecordElement RecordsConfig[] = // {RECT_CONFIG, "proxy.

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/632#discussion_r63074614 --- Diff: mgmt/RecordsConfig.cc --- @@ -1976,6 +1976,8 @@ static const RecordElement RecordsConfig[] = // {RECT_CONFIG, "proxy.c

FYI: traffic_line removed from 7.0 branch

2016-05-12 Thread James Peach
Hi all, Just a heads-up in case. We have removed traffic_line in preparation for the 7.0 release. If you have any tooling that uses traffic_line, now is the time to switch over to traffic_ctl. Please file bugs if you find any problems with traffic_ctl or have any suggestions for features. than

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/632#issuecomment-218847465 This is running on docs.trafficserver right now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] trafficserver pull request: TS-3670: Remove traffic_line.

2016-05-12 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/633 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-3670: Remove traffic_line.

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/633#issuecomment-218846704 I agree with atsci, ship it! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/632#issuecomment-218822758 This is second patch after the #525 and TS-4295. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver pull request: TS-3670: Remove traffic_line.

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/633#issuecomment-218818643 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/14/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-3670: Remove traffic_line.

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/633#issuecomment-218818425 Linux (CentOS7) build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-Linux/31/ --- If your project is set up for it, you c

[GitHub] trafficserver pull request: TS-3670: Remove traffic_line.

2016-05-12 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/633 TS-3670: Remove traffic_line. Remove ``traffic_line`` and references to it. You can merge this pull request into a Git repository by running: $ git pull https://github.com/jpeach/traffics

[GitHub] trafficserver pull request: TS-4032: Enable command line based mes...

2016-05-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/628#discussion_r63054437 --- Diff: mgmt/api/CoreAPI.h --- @@ -45,10 +45,11 @@ TSProxyStateT ProxyStateGet(); TSMgmtError ProxyStateSet(TSProxyStateT state, TSCacheClearT cle

[GitHub] trafficserver pull request: TS-4032: Enable command line based mes...

2016-05-12 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/628#discussion_r63054174 --- Diff: mgmt/api/CoreAPI.h --- @@ -45,10 +45,11 @@ TSProxyStateT ProxyStateGet(); TSMgmtError ProxyStateSet(TSProxyStateT state, TSCacheClearT clea

[GitHub] trafficserver pull request: TS-4032: Enable command line based mes...

2016-05-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/628#discussion_r63054150 --- Diff: proxy/Main.cc --- @@ -1972,6 +1974,31 @@ mgmt_storage_device_cmd_callback(void *data, char *arg, int len) return NULL; }

[GitHub] trafficserver pull request: TS-4032: Enable command line based mes...

2016-05-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/628#discussion_r63053644 --- Diff: mgmt/api/CoreAPI.h --- @@ -45,10 +45,11 @@ TSProxyStateT ProxyStateGet(); TSMgmtError ProxyStateSet(TSProxyStateT state, TSCacheClearT cle

[GitHub] trafficserver pull request: TS-4435: Enable compilation with opens...

2016-05-12 Thread jpeach
Github user jpeach commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/630#discussion_r63051780 --- Diff: iocore/net/SSLUtils.cc --- @@ -440,7 +444,7 @@ static DH * get_dh2048() --- End diff -- It would be nice to rename this to ``

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/632#issuecomment-218811459 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/13/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/632#issuecomment-21881 Linux (CentOS7) build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-Linux/30/ --- If your project is set up for it, you c

[GitHub] trafficserver pull request: TS-3535: Experimental Support of HTTP/...

2016-05-12 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/632 TS-3535: Experimental Support of HTTP/2 Stream Priority feature This is an experimental support of HTTP/2 Stream Priority feature. - Add a option to enable this feature ( disabled

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218808069 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/12/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218808343 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/11/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218807940 Linux (CentOS7) build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-Linux/29/ --- If your project is set up for it, you c

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218805451 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/10/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218805119 Linux (CentOS7) build failed! Details on https://ci.trafficserver.apache.org/job/Github-Linux/28/ --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218804213 Linux (CentOS7) build failed! Details on https://ci.trafficserver.apache.org/job/Github-Linux/27/ --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218803315 Linux (CentOS7) build failed! Details on https://ci.trafficserver.apache.org/job/Github-Linux/26/ --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218799509 Linux (CentOS7) build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-Linux/25/ --- If your project is set up for it, you c

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218798722 FreeBSD v10 build finished successfully. Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/9/ --- If your project is set up for it, you can

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218796438 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218791900 FreeBSD v10 build failed! Details on https://ci.trafficserver.apache.org/job/Github-FreeBSD/7/ --- If your project is set up for it, you can reply to this e

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread jacksontj
Github user jacksontj commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218790124 @zwoop looks like @atsci is having some sort of issue: ```GitHub pull request #631 of commit 6b8b86a2ec8329181649d56c6853a1d79d595a07, no merge conflicts.

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/631#issuecomment-218789806 Linux (CentOS7) build failed! Details on https://ci.trafficserver.apache.org/job/Github-Linux/22/ --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: TS-4436: Move hosts file implementatio...

2016-05-12 Thread jacksontj
GitHub user jacksontj opened a pull request: https://github.com/apache/trafficserver/pull/631 TS-4436: Move hosts file implementation to `do_dns` This moves the hosts file overrides down to the DNS layer instead of the HostDBInfo layer. This means that each port will get its own ent

[GitHub] trafficserver pull request: Add new limit rate example plugin

2016-05-12 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/615#issuecomment-218788246 Not sure why you couldn't create the Jira, but I made one for you: https://issues.apache.org/jira/browse/TS-4437. All you should have to do is to register with the

[GitHub] trafficserver pull request: TS-3607: Integrate ats_pagespeed into ...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/210#issuecomment-218782640 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: TS-4072 Diagnostic log rolling races

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/568#issuecomment-218782605 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: TS-3245 : Changes optind = 1 to optind...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/571#issuecomment-218782597 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: TS-3792: Crash with non-existant or mi...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/262#issuecomment-218782633 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: UUID Proposal

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/199#issuecomment-218782646 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: [TS-4103] mocks

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/408#issuecomment-218782624 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: Converted Apache::TS::AdminClient to u...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/35#issuecomment-218782660 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: AARCH64 fixes tested on Cavium Thunder...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/502#issuecomment-218782620 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/593#issuecomment-218782581 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: TS-4274 Use the right hostdb levels as...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/536#issuecomment-218782613 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: Add new limit rate example plugin

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/615#issuecomment-218782568 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: [TS-4379] Add log field for Server Con...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/598#issuecomment-218782575 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: Added (Estimated) Round Trip Time acce...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/123#issuecomment-218782655 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: TS-3978: Allow empty document caching ...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/310#issuecomment-218782631 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: TS-4410 : Fixed compiler warning on i3...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/611#issuecomment-218782573 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: TS-4291 Adds log field "pqnhl" which i...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/588#issuecomment-218782592 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: [TS-4408] Make volume.config not order...

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/618#issuecomment-218782561 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request: C++ API WebSocket example

2016-05-12 Thread atsci
Github user atsci commented on the pull request: https://github.com/apache/trafficserver/pull/624#issuecomment-218782549 Can one of the admins verify this patch? Only approve PRs which have been reviewed. --- If your project is set up for it, you can reply to this email and have your