[GitHub] trafficserver pull request: TS-4387 Add enforement of TSCont havin...

2016-04-26 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/603#issuecomment-214967102 s/enforement/enforcement/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver pull request: Remove ParentResult::epoch field.

2016-04-26 Thread jpeach
GitHub user jpeach opened a pull request: https://github.com/apache/trafficserver/pull/604 Remove ParentResult::epoch field. ParentResult::epoch was set but never used for anything other than logging. Let's remove it to save some space and improve clarity. You can merge this pul

[GitHub] trafficserver pull request: TS-3429: Fix reference counting for TS...

2016-04-26 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/576#issuecomment-214966094 This looks good to me too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Re: wrt custom logging field

2016-04-26 Thread Miles Libbey
Put the value in a header, then log that header value? miles On Tuesday, April 26, 2016 8:58 PM, Akbar Saidov wrote: Hello, I would like to know if it is possible to define/create new custom logging field without modifying the traffic server core code (logging module, i.e. within traffi

wrt custom logging field

2016-04-26 Thread Akbar Saidov
Hello, I would like to know if it is possible to define/create new custom logging field without modifying the traffic server core code (logging module, i.e. within trafficserver/proxy/logging/ ) ? In other words, I was wondering if there is any dictionary or a config file perhaps, or even an API

[GitHub] trafficserver pull request: TS-4387 Add enforement of TSCont havin...

2016-04-26 Thread bgaff
Github user bgaff commented on the pull request: https://github.com/apache/trafficserver/pull/603#issuecomment-214954641 Yep I'm 👍 on this too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-26 Thread masaori335
Github user masaori335 closed the pull request at: https://github.com/apache/trafficserver/pull/600 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

Re: Sharing data across plug-ins

2016-04-26 Thread Karthik Sivaraman
Thanks Leif Karthik From: Leif Hedstrom Sent: Monday, April 25, 2016 6:35:30 PM To: dev@trafficserver.apache.org; Karthik Sivaraman Subject: Re: Sharing data across plug-ins > On Apr 25, 2016, at 7:21 PM, Karthik Sivaraman > wrote: > > Hi > > > I want

Re: [Feature request] Add a hard limit config to content lifetime

2016-04-26 Thread Hiroaki Nakamura
2016-04-27 1:26 GMT+09:00 Leif Hedstrom : > >> On Apr 26, 2016, at 10:21 AM, Hiroaki Nakamura wrote: >> >> Yes, I understand it now. >> >> So what I need to do is: >> In TS_HTTP_READ_RESPONSE_HDR_HOOK modify Cache-Control: s-maxage if >> the value is too long. >> > > > Does ttl-in-cache= in cach

[GitHub] trafficserver pull request: TS-4387 Add enforement of TSCont havin...

2016-04-26 Thread zwoop
Github user zwoop commented on the pull request: https://github.com/apache/trafficserver/pull/603#issuecomment-214921716 This basically restores previous behavior right? If so, +1. Also, this should get back ported to 6.2.x IMO. --- If your project is set up for it, you can reply to

[GitHub] trafficserver pull request: TS-4387 Add enforement of TSCont havin...

2016-04-26 Thread shenzhang920
GitHub user shenzhang920 opened a pull request: https://github.com/apache/trafficserver/pull/603 TS-4387 Add enforement of TSCont having MUTEX for TSContSchedule() https://issues.apache.org/jira/browse/TS-4387 You can merge this pull request into a Git repository by running: $

[GitHub] trafficserver pull request: TS-4364: Address remnants from HTTP/2 ...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/584 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4387 Add enforement of TSCont havin...

2016-04-26 Thread shenzhang920
Github user shenzhang920 closed the pull request at: https://github.com/apache/trafficserver/pull/602 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] trafficserver pull request: TS-4055: another clean up fix to elimi...

2016-04-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/585 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: TS-4387 Add enforement of TSCont havin...

2016-04-26 Thread shenzhang920
GitHub user shenzhang920 opened a pull request: https://github.com/apache/trafficserver/pull/602 TS-4387 Add enforement of TSCont having MUTEX for TSContSchedule() https://issues.apache.org/jira/browse/TS-4387 You can merge this pull request into a Git repository by running: $

[GitHub] trafficserver pull request: TS-4055: InactivityCop callback SM wit...

2016-04-26 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/373#issuecomment-214905902 It looks like @bcall merged it up as part of f17e7c6ddf8d771b3dc21b59360e982c55423c46 but mislabeled it for TS-4056. So it is definitely in there. --- If you

[GitHub] trafficserver pull request: TS-3429: Fix reference counting for TS...

2016-04-26 Thread shinrich
Github user shinrich commented on the pull request: https://github.com/apache/trafficserver/pull/576#issuecomment-214851707 @jpeach Any other thoughts here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [Feature request] Add a hard limit config to content lifetime

2016-04-26 Thread Leif Hedstrom
> On Apr 26, 2016, at 10:21 AM, Hiroaki Nakamura wrote: > > Yes, I understand it now. > > So what I need to do is: > In TS_HTTP_READ_RESPONSE_HDR_HOOK modify Cache-Control: s-maxage if > the value is too long. > Does ttl-in-cache= in cache.config do what you expect? —= leif

Re: [Feature request] Add a hard limit config to content lifetime

2016-04-26 Thread Hiroaki Nakamura
Yes, I understand it now. So what I need to do is: In TS_HTTP_READ_RESPONSE_HDR_HOOK modify Cache-Control: s-maxage if the value is too long. Thanks for your help again! 2016-04-27 1:18 GMT+09:00 Kit Chan : > Similar to the other email thread that is ongoing, you can override cache > control he

Re: [Feature request] Add configs to ignore server Cache-Control: max-age and Expires

2016-04-26 Thread Hiroaki Nakamura
I read the mail you refer to. I understand that I can achieve my requirement with the following steps: 1. In TS_HTTP_READ_RESPONSE_HDR_HOOK, remove Expires and Cache-Control: max-age headers and keep the values in the request context. 2. In TS_HTTP_SEND_RESPONSE_HDR_HOOK, restore Expires and Cache

Re: [Feature request] Add a hard limit config to content lifetime

2016-04-26 Thread Kit Chan
Similar to the other email thread that is ongoing, you can override cache control header in read response hook to achieve that Sent from my iPhone > On Apr 26, 2016, at 8:55 AM, Hiroaki Nakamura wrote: > > Hi all, > > I would like to add a hard limit config to contents lifetime. > I would lik

[Feature request] Add a hard limit config to content lifetime

2016-04-26 Thread Hiroaki Nakamura
Hi all, I would like to add a hard limit config to contents lifetime. I would like to limit (say 30 days) lifetime even when a longer value is set in the "Cache-Control: s-maxage" response header from the origin server. I want to apply this limit when a content is cached. I looked through https:/

Re: [Feature request] Add configs to ignore server Cache-Control: max-age and Expires

2016-04-26 Thread Sudheer Vinukonda
Er..Sorry, I realize that email thread is doing the opposite of what you are asking..but, nevertheless, the fact that CC headers can be modified during READ_RESPONSE_HDR_HOOK and still impact the cache-ability of the response, still holds and you can flip them the way you want. On Tuesday, Ap

Re: [Feature request] Add configs to ignore server Cache-Control: max-age and Expires

2016-04-26 Thread Sudheer Vinukonda
>>> Can we specify whether a content is cacheable or not in >>> TS_HTP_READ_RESPONSE_HDR_HOOK? Yes, I believe so - there are a couple of techniques mentioned in the below email thread to do that..please give either a shot and let us know if it works for your usecase.. http://mail-archives.apac

Re: [Feature request] Add configs to ignore server Cache-Control: max-age and Expires

2016-04-26 Thread Hiroaki Nakamura
Thanks for your resonses. 2016-04-27 0:21 GMT+09:00 Leif Hedstrom : > >> On Apr 26, 2016, at 8:48 AM, Sudheer Vinukonda >> wrote: >> >> Can you pls create a jira with the requirement and proposed solution? I created a jira issue. https://issues.apache.org/jira/browse/TS-4386 >> Btw, reading th

Re: [Feature request] Add configs to ignore server Cache-Control: max-age and Expires

2016-04-26 Thread Leif Hedstrom
> On Apr 26, 2016, at 8:48 AM, Sudheer Vinukonda > wrote: > > Can you pls create a jira with the requirement and proposed solution? > Btw, reading the email, this seems like something that can be achieved via a > plugin API. Agreed. Some thoughts has to be put into this, to make sure that we

Re: [Feature request] Add configs to ignore server Cache-Control: max-age and Expires

2016-04-26 Thread Sudheer Vinukonda
Can you pls create a jira with the requirement and proposed solution? Btw, reading the email, this seems like something that can be achieved via a plugin API. Thanks, Sudheer On Monday, April 25, 2016 6:18 PM, Hiroaki Nakamura wrote: Hi all, I would like to add configs to ignore serve

[GitHub] trafficserver pull request: TS-4328

2016-04-26 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/554#issuecomment-214694979 Oh, in any case, I haven't really checked carefully, but I actually wonder if the milestone (server begin write) in question here is reset for "each" server leg

[GitHub] trafficserver pull request: TS-4328

2016-04-26 Thread sudheerv
Github user sudheerv commented on the pull request: https://github.com/apache/trafficserver/pull/554#issuecomment-214693606 The problem is that you are trying to "mix" the internals of a completely independent/different feature to use for an unrelated/unintended purposes. This sets a