Re: Proposal: NetVC Context

2016-04-24 Thread Chao Xu
Hi James, > Each side would be a separate NetVConnection. Yes, Each side is a separate NetVC and Socket FD, thus every side has client and server. for Client Side Context: 1. if no transparent enabled: get_client_addr() = get_remote_addr() is client ip address. get_server_addr() = get_local

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-24 Thread masaori335
Github user masaori335 commented on the pull request: https://github.com/apache/trafficserver/pull/600#issuecomment-214095730 @shinrich Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] trafficserver pull request: TS-4355: Change assert condition for T...

2016-04-24 Thread masaori335
GitHub user masaori335 opened a pull request: https://github.com/apache/trafficserver/pull/600 TS-4355: Change assert condition for TS-3612 You can merge this pull request into a Git repository by running: $ git pull https://github.com/masaori335/trafficserver ts-4355 Alterna

[GitHub] trafficserver pull request: Update I_Action.h

2016-04-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/trafficserver/pull/547 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Update I_Action.h

2016-04-24 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/546#issuecomment-214077247 Closing as duplicate of #547. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-24 Thread David Calavera
The name change makes sense to me. I'll make the change everywhere in my PR tomorrow if everyone agrees with it. To be clear: - Method to create SSL server context: `TSSslServerContextCreate` - Method to destroy any kind of SSL context: `TSSslContextDestroy` On Sun, Apr 24, 2016 at 2:57 PM, James

Re: Add TSSslContextCreate and TSSslContextDestroy to the API

2016-04-24 Thread James Peach
This looks pretty reasonable to me. One concern I have is that this API creates SSL server contexts, so we ought to distinguish that in the API name. I propose that TSSslContextCreate() be named TSSslServerContextCreate(), and that we define TSSslContextDestroy() will be able to destroy both ser

[GitHub] trafficserver pull request: TS-4187: Keep the currently_open conne...

2016-04-24 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/583#issuecomment-214042536 This looks good to me. I think it should be reasonable to construct a simple integration test for this? --- If your project is set up for it, you can reply to thi

[GitHub] trafficserver pull request: Add TSSslContextCreate method

2016-04-24 Thread jpeach
Github user jpeach closed the pull request at: https://github.com/apache/trafficserver/pull/402 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request: Add TSSslContextCreate method

2016-04-24 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/402#issuecomment-214042675 Closing in favor of #594. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] trafficserver pull request: TS-3245 : Changes optind = 1 to optind...

2016-04-24 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/571#issuecomment-214041833 Note to self: check what glibc does with ``optind=1``, which is the pattern used by remap plugins. --- If your project is set up for it, you can reply to this ema

[GitHub] trafficserver pull request: TS-4156: remove the traffic_sac, stand...

2016-04-24 Thread jpeach
Github user jpeach commented on the pull request: https://github.com/apache/trafficserver/pull/593#issuecomment-214041764 Could you please remove these remaining references: ``` $ git grep traffic_sac .gitignore:proxy/traffic_sac doc/locale/ja/LC_MESSAGES/admin/working-l

[GitHub] trafficserver pull request: TS-4116: DNS failure prohibits use of ...

2016-04-24 Thread ushachar
Github user ushachar closed the pull request at: https://github.com/apache/trafficserver/pull/599 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: Proposal: NetVC Context

2016-04-24 Thread James Peach
> On Apr 22, 2016, at 7:28 PM, Chao Xu wrote: > > As a proxy, there has two side: client side ( Client <-> Proxy ) and server > side ( Proxy <-> Server ). Each side would be a separate NetVConnection. > Add a new member 'netvc_context' into class NetVConnection to indicate > which side the Net