Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/577#discussion_r60173886
--- Diff: proxy/hdrs/HTTP.h ---
@@ -796,12 +796,13 @@ HTTPHdr::create(HTTPType polarity, HdrHeap *heap)
}
inline void
-HTTPHdr::clear(
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/576#issuecomment-211721466
I just feel like a lot can go wrong here, suppose I did a TSContCall w/
event = 2, that would cause event counts to increase and ultimately a memory
leak...thoughts
Github user bgaff commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/576#discussion_r60170878
--- Diff: proxy/InkAPI.cc ---
@@ -991,7 +991,16 @@ INKContInternal::handle_event(int event, void *edata)
Warning("INKCont Deletable but not del
Github user gtenev commented on the pull request:
https://github.com/apache/trafficserver/pull/582#issuecomment-211700790
Sounds good, will add the message.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/582#issuecomment-211697775
Should we also add a ``TSError`` message at cache url load time?
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/582
TS-4356 Deprecate cacheurl plugin
Added a "deprecated" message and `cachekey` examples to the `cacheurl` doc.
You can merge this pull request into a Git repository by running:
$ git pull
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/578#issuecomment-211695320
Can you please update
https://github.com/apache/trafficserver/blob/master/ci/tsqa/tests/test_https.py
to test this case?
---
If your project is set up for it, yo
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/578#issuecomment-211685166
Seems reasonable to me ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does no
GitHub user masaori335 opened a pull request:
https://github.com/apache/trafficserver/pull/581
TS-4361: Remove TS_FETCH_EVENT handlers from Http2ClientSession
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/masaori335/trafficserv
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/580
TS-4318 Fix a regression in regex rules
The refactoring done earlier broke the config loading of rules using
the regular expressions. This restore that functionality, but cleaner.
You can m
Github user shinrich commented on the pull request:
https://github.com/apache/trafficserver/pull/576#issuecomment-211571394
Agreed that this is snakey logic. Should take necessary time to review.
I just pushed a new version (will squash at the end). Changed the assert
as sug
GitHub user gtenev opened a pull request:
https://github.com/apache/trafficserver/pull/579
TS-4147 Allow gzip plugin to be a remap plugin
pull request on behalf of @meeramn
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gtenev/t
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/578
TS-4180: Support for multiple intermediate cert chains
Previous fix parsed the comma separated file names, but would only load the
first file.
You can merge this pull request into a Git rep
Github user bgaff commented on the pull request:
https://github.com/apache/trafficserver/pull/576#issuecomment-211516035
I also have comments as I recently found another bug related to
TSContSchedulde/Every
Brian
On Tuesday, April 19, 2016, James Peach wrote:
Github user jpeach commented on the pull request:
https://github.com/apache/trafficserver/pull/576#issuecomment-211506570
I'd like to review this a bit more ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your proj
Will fix in a few hours.
On Monday, April 18, 2016, James Peach wrote:
>
> > On Apr 18, 2016, at 1:05 AM, bri...@apache.org wrote:
> >
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > briang pushed a commit to branch master
> > in repository https://git-dual.apach
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/576#discussion_r60103328
--- Diff: proxy/InkAPI.cc ---
@@ -991,7 +991,14 @@ INKContInternal::handle_event(int event, void *edata)
Warning("INKCont Deletable but not de
Github user zwoop commented on the pull request:
https://github.com/apache/trafficserver/pull/576#issuecomment-211473667
Looks good to me! I think this should fix at least two Jira's :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on Gi
GitHub user SolidWallOfCode opened a pull request:
https://github.com/apache/trafficserver/pull/577
TS-4046: Prevent memory leak of HTTP heap for server intercept case.
In the case of an intercept plugin the `client_response` can be leaked. I
changed the method used to be `destroy`
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/576
TS-3429: Fix reference counting for TSContScheduleEvery.
Changed the logic at the end of the INKContInternal event handler to bump
up the ref-count at the end if it was invoked for an interv
> On Apr 18, 2016, at 1:05 AM, bri...@apache.org wrote:
>
> This is an automated email from the ASF dual-hosted git repository.
>
> briang pushed a commit to branch master
> in repository https://git-dual.apache.org/repos/asf/trafficserver.git
>
> The following commit(s) were added to refs/head
Github user asfgit closed the pull request at:
https://github.com/apache/trafficserver/pull/574
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
22 matches
Mail list logo
